Hello, Same dumb method as usual from me.
Le Tuesday 05 August 2008, Aaron J. Seigo a écrit : > the affected classes are Containment, with a setter and getter for the > wallpaper I'd probably add a setWallpaper(Wallpaper*) so that the setter/getter couple becomes symetric with an extra convenience version (the one doing the load for you). > and the new class Wallpaper. A few comments: * I think it's worth it to have the "icon" property too * I don't get what the "mode" thing is about. Any more specific use case? I admit I had to look for the apidox for this one. I found a small blurb in the class apidox about modes, but from the relevant methods there's nothing about what the modes are. Last, the class apidox didn't make me figure out what they are exactly (switch to using an "Action" term at some point). * Depending on what we figure out regarding what the modes are, it might be worth it to have a small "WallpaperMode" class (it holds already three properties, and could grow). * I don't get the action parameter from the init() method (but since I didn't understand th mode thing, that's probably related). Other than that it's all clear on my side. Regards. -- Kévin 'ervin' Ottens, http://ervin.ipsquad.net "Ni le maître sans disciple, Ni le disciple sans maître, Ne font reculer l'ignorance."
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
