Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/ --- (Updated July 29, 2017, 10:26 a.m.) Status -- This change has been m

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/#review103505 --- Ship it! Ship It! - Sebastian Kügler On Dec. 27, 2016,

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/#review103497 --- So can we commit this then? - Albert Astals Cid On Dec. 2

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 27, 2016, 4:54 p.m., Sebastian Kügler wrote: > > applets/digital-clock/plugin/timezonesi18n.cpp, line 682 > > > > > > This should stay Cape Verde, the English name is used here, not the > > Portuguese

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 27, 2016, 3:54 p.m., Sebastian Kügler wrote: > > applets/digital-clock/plugin/timezonesi18n.cpp, line 682 > > > > > > This should stay Cape Verde, the English name is used here, not the > > Portuguese

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/ --- (Updated Dec. 27, 2016, 5:48 p.m.) Review request for Plasma and Albert A

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 27, 2016, 4:54 p.m., Sebastian Kügler wrote: > > applets/digital-clock/plugin/timezonesi18n.cpp, line 682 > > > > > > This should stay Cape Verde, the English name is used here, not the > > Portuguese

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 27, 2016, 3:54 p.m., Sebastian Kügler wrote: > > applets/digital-clock/plugin/timezonesi18n.cpp, line 682 > > > > > > This should stay Cape Verde, the English name is used here, not the > > Portuguese

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 27, 2016, 3:54 p.m., Sebastian Kügler wrote: > > applets/digital-clock/plugin/timezonesi18n.cpp, line 682 > > > > > > This should stay Cape Verde, the English name is used here, not the > > Portuguese

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/#review101595 --- In principle good, but Cabo Verde should not be changed. Can

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 21, 2016, 12:25 a.m., Aleix Pol Gonzalez wrote: > > +0 > > > > Note the correct patch would possibly be to port it to > > http://doc.qt.io/qt-5/qtimezone.html and drop that list... Btw. this list exists because there is(/was) no way to get localized list of all countries from QTimeZ

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 20, 2016, 11:46 p.m., Pino Toscano wrote: > > TBH I don't think the Congo and CZ changes are somehow needed, since the > > current names are already the official names for the countries. > > Jiri Bohac wrote: > The reason is consistency. > The short names are used for all the

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 20, 2016, 10:46 p.m., Pino Toscano wrote: > > TBH I don't think the Congo and CZ changes are somehow needed, since the > > current names are already the official names for the countries. > > Jiri Bohac wrote: > The reason is consistency. > The short names are used for all the

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/#review101524 --- +0 Note the correct patch would possibly be to port it to

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 20, 2016, 10:46 p.m., Pino Toscano wrote: > > TBH I don't think the Congo and CZ changes are somehow needed, since the > > current names are already the official names for the countries. The reason is consistency. The short names are used for all the remaining countries. It's inconsis

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/#review101522 --- TBH I don't think the Congo and CZ changes are somehow neede