> On Dec. 20, 2016, 10:46 p.m., Pino Toscano wrote: > > TBH I don't think the Congo and CZ changes are somehow needed, since the > > current names are already the official names for the countries.
The reason is consistency. The short names are used for all the remaining countries. It's inconsistent to use the long name for two of them. Political names are not meant to be used in UI. You don't see "French Republic" or "Federal Republic of Germany" in dropdown lists. CZ and CG now have an official short name just as the others, so it should be used just as the others'. - Jiri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/#review101522 ----------------------------------------------------------- On Dec. 20, 2016, 9:57 p.m., Jiri Bohac wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129691/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2016, 9:57 p.m.) > > > Review request for Plasma and Albert Astals Cid. > > > Repository: plasma-workspace > > > Description > ------- > > Update the list of country names to the current names in iso-codes > (as output by isoquery -c). > > The motivation is updating the name of Czechia as a followup to > https://git.reviewboard.kde.org/r/129644/ > As suggested by Albert Astals Cid, fixing the name in i10n is not enough: > country names are hardcoded in many places and they need to be fixed > separately. > > > Diffs > ----- > > applets/digital-clock/plugin/timezonesi18n.cpp 10650f8 > > Diff: https://git.reviewboard.kde.org/r/129691/diff/ > > > Testing > ------- > > > Thanks, > > Jiri Bohac > >
