> On Dec. 27, 2016, 4:54 p.m., Sebastian Kügler wrote: > > applets/digital-clock/plugin/timezonesi18n.cpp, line 682 > > <https://git.reviewboard.kde.org/r/129691/diff/1/?file=487931#file487931line682> > > > > This should stay Cape Verde, the English name is used here, not the > > Portuguese (?) one. > > Jiri Bohac wrote: > Frankly, I don't understand what all the discussion here is about. > I noticed the list of countries, obviously taken from iso-codes some day > in the past, was out of date. > The comment above the hash table clearly says "Make sure the country > names match their versions in iso-codes". > So I went and fixed everything to the current version of the ISO > standard. > > Suddenly, people start disputing the changes with reasoning like: > "This should stay Cape Verde, the English name is used here, not the > Portuguese" > "Czech Republic" is correct as well, since it's the official name" > "Congo" is IMHO way too ambiguous > > I am no expert on naming countries. There are whole commities doing that > at UN and ISO. They decided that > "Czechia", "Congo" and "Cabo Verde" are the correct short names and > updated their databases/standards. > > I would have loved [not] to see such a discussion when populating this > hash table from scratch :)) > > I find it totally unsystematic to maitain a few records out of sync with > iso-codes. Either by using an old version (Cabo Verde) or not using a newly > standardized short version. Why would anyone think the snapshot of iso_3116 > from ~1 year ago was good and suddenly new ammendment to the standard are > controversial? > > If someone, who is a better expert on international politics and > territory naming than the UN, feels they want to use any subset of my > changes, feel free to do that. I totally don't understand any reasoning > behind that, though. > > Sebastian Kügler wrote: > I can't comment on the other changes (In fact, I ACK'ed them, so I > explicitely didn't), but when I looked up Cabo Verde, all I could find is the > English version, so Cape Verde. If you have a more recent version, I'm all > open for it. If you're posting reviews just to have them rubber-stamped by a > robot who doesn't actually review and think the changes through, that's not > what our code reviews is about. > > I agree that it's a PITA to maintain the list in several places.
> people start disputing the changes with reasoning like: > "Czech Republic" is correct as well, since it's the official name" I never disputed anything, I merely stated that personally, as a Czech, I prefer "Czech Republic" over "Czechia" and even explicitly said that my comment is not to block your change. Please don't take my words out of context. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/#review101595 ----------------------------------------------------------- On Dec. 20, 2016, 10:57 p.m., Jiri Bohac wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129691/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2016, 10:57 p.m.) > > > Review request for Plasma and Albert Astals Cid. > > > Repository: plasma-workspace > > > Description > ------- > > Update the list of country names to the current names in iso-codes > (as output by isoquery -c). > > The motivation is updating the name of Czechia as a followup to > https://git.reviewboard.kde.org/r/129644/ > As suggested by Albert Astals Cid, fixing the name in i10n is not enough: > country names are hardcoded in many places and they need to be fixed > separately. > > > Diffs > ----- > > applets/digital-clock/plugin/timezonesi18n.cpp 10650f8 > > Diff: https://git.reviewboard.kde.org/r/129691/diff/ > > > Testing > ------- > > > Thanks, > > Jiri Bohac > >
