Re: Review Request: Status notifier item data engine

2010-03-17 Thread Matthieu Gallien
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3266/ --- (Updated 2010-03-17 23:12:45.067867) Review request for Plasma. Changes --

Re: Review Request: Status notifier item data engine

2010-03-17 Thread Marco Martin
On Wednesday 17 March 2010, Aaron J. Seigo wrote: > On March 17, 2010, Matthieu Gallien wrote: > > Should I request an SVN account and put you Marco as the referee ? > > +1 +1 from me as well :) Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-

Re: Review Request: Status notifier item data engine

2010-03-17 Thread Aaron J. Seigo
On March 17, 2010, Matthieu Gallien wrote: > Should I request an SVN account and put you Marco as the referee ? +1 -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks _

Re: Review Request: Status notifier item data engine

2010-03-17 Thread Matthieu Gallien
> On 2010-03-12 11:58:14, Marco Martin wrote: > > apart some style issues this should go in because the modifications are > > already too big (Aurelien has a patch on it too, you should also update to > > include it one he committed) > > Matthieu Gallien wrote: > I will post an updated pat

Re: Review Request: Status notifier item data engine

2010-03-14 Thread Marco Martin
On Sun, Mar 14, 2010 at 6:39 PM, Matthieu Gallien wrote: > > >> On 2010-03-12 11:56:42, Marco Martin wrote: >> > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/plasma_engine_statusnotifieritem.desktop, >> > line 37 >> >

Re: Review Request: Status notifier item data engine

2010-03-14 Thread Matthieu Gallien
> On 2010-03-12 11:58:14, Marco Martin wrote: > > apart some style issues this should go in because the modifications are > > already too big (Aurelien has a patch on it too, you should also update to > > include it one he committed) I will post an updated patch soon. I am working on updating

Re: Review Request: Status notifier item data engine

2010-03-14 Thread Matthieu Gallien
> On 2010-03-12 11:56:42, Marco Martin wrote: > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/plasma_engine_statusnotifieritem.desktop, > > line 37 > > > > > > should be Engine for Appli

Re: Review Request: Status notifier item data engine

2010-03-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3266/#review4483 --- Ship it! apart some style issues this should go in because the modifi

Re: Review Request: Status notifier item data engine

2010-03-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3266/#review4481 --- /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnot