----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3266/ -----------------------------------------------------------
(Updated 2010-03-17 23:12:45.067867) Review request for Plasma. Changes ------- Add changes by Aurelien and verified that other changes are in. >From my testing, this is final for the dataengine. By the way, I applied for the SVN account and had no time to finish the patch for the applet. I hope to have more time tomorrow. Summary ------- Data engine that exposes one source by status notifier item. The code is a copy of the code from Marco Martin and that is in the systray applet dbus protocol. I will when I found enough time review that I did not introduce any bug or that I miss any modifications that occured in the applet code. I started this work several months ago, so I may be missing something. Diffs (updated) ----- /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/plasma_engine_statusnotifieritem.desktop PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritem.operations PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritem_engine.h PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemjob.h PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemjob.cpp PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemservice.h PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemservice.cpp PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemsource.h PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemsource.cpp PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifierwatcher/CMakeLists.txt PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifierwatcher/statusnotifierwatcher.desktop PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifierwatcher/statusnotifierwatcher.h PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifierwatcher/statusnotifierwatcher.cpp PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/systemtraytypes.h PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/systemtraytypes.cpp PRE-CREATION Diff: http://reviewboard.kde.org/r/3266/diff Testing ------- Tested in plasmaengineexplorer. Thanks, Matthieu _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
