> On 2010-03-12 11:56:42, Marco Martin wrote: > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/plasma_engine_statusnotifieritem.desktop, > > line 37 > > <http://reviewboard.kde.org/r/3266/diff/1/?file=20665#file20665line37> > > > > should be Engine for Applications status information based on the > > StatusNotifier protocol.
Thanks for the help. Should I keep the default generated lines for the translations ? > On 2010-03-12 11:56:42, Marco Martin wrote: > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp, > > line 29 > > <http://reviewboard.kde.org/r/3266/diff/1/?file=20668#file20668line29> > > > > class names with CamelCase names and never ever underscores Corrected and me goes hiding under a very big rock > On 2010-03-12 11:56:42, Marco Martin wrote: > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifierwatcher/statusnotifierwatcher.h, > > line 1 > > <http://reviewboard.kde.org/r/3266/diff/1/?file=20677#file20677line1> > > > > is this file moved with svn mv? > > this is quite important since is the only way to preserve history I started this work a long time ago and used a local git repository. I will prepare a patch that is contains the svn mv. I do not have a SVN account, so you will have to commit this for me. > On 2010-03-12 11:56:42, Marco Martin wrote: > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/systemtraytypes.cpp, > > line 67 > > <http://reviewboard.kde.org/r/3266/diff/1/?file=20680#file20680line67> > > > > extra space done - Matthieu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3266/#review4481 ----------------------------------------------------------- On 2010-03-11 21:34:08, Matthieu Gallien wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3266/ > ----------------------------------------------------------- > > (Updated 2010-03-11 21:34:08) > > > Review request for Plasma. > > > Summary > ------- > > Data engine that exposes one source by status notifier item. > The code is a copy of the code from Marco Martin and that is in the systray > applet dbus protocol. > I will when I found enough time review that I did not introduce any bug or > that I miss any modifications that occured in the applet code. > I started this work several months ago, so I may be missing something. > > > Diffs > ----- > > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/plasma_engine_statusnotifieritem.desktop > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritem.operations > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritem_engine.h > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemjob.h > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemjob.cpp > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemservice.h > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemservice.cpp > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemsource.h > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemsource.cpp > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifierwatcher/CMakeLists.txt > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifierwatcher/statusnotifierwatcher.desktop > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifierwatcher/statusnotifierwatcher.h > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifierwatcher/statusnotifierwatcher.cpp > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/systemtraytypes.h > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/systemtraytypes.cpp > PRE-CREATION > > Diff: http://reviewboard.kde.org/r/3266/diff > > > Testing > ------- > > Tested in plasmaengineexplorer. > > > Thanks, > > Matthieu > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
