> On 2010-03-12 11:58:14, Marco Martin wrote: > > apart some style issues this should go in because the modifications are > > already too big (Aurelien has a patch on it too, you should also update to > > include it one he committed) > > Matthieu Gallien wrote: > I will post an updated patch soon. > I am working on updating it with respect to all commits made on the code > in the applet since I started this work. > I finished a first version of the applet using completly the dataengine. > It seems the icons are not correctly exported by the data engine. > I will try to see if I can modify plasmaengineexplorer in order to see my > icons in its view.
I will finish this evening the port to the modifications of Aurélien. I will then update the review request. Should I request an SVN account and put you Marco as the referee ? - Matthieu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3266/#review4483 ----------------------------------------------------------- On 2010-03-11 21:34:08, Matthieu Gallien wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3266/ > ----------------------------------------------------------- > > (Updated 2010-03-11 21:34:08) > > > Review request for Plasma. > > > Summary > ------- > > Data engine that exposes one source by status notifier item. > The code is a copy of the code from Marco Martin and that is in the systray > applet dbus protocol. > I will when I found enough time review that I did not introduce any bug or > that I miss any modifications that occured in the applet code. > I started this work several months ago, so I may be missing something. > > > Diffs > ----- > > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/plasma_engine_statusnotifieritem.desktop > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritem.operations > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritem_engine.h > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemjob.h > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemjob.cpp > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemservice.h > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemservice.cpp > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemsource.h > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemsource.cpp > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifierwatcher/CMakeLists.txt > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifierwatcher/statusnotifierwatcher.desktop > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifierwatcher/statusnotifierwatcher.h > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifierwatcher/statusnotifierwatcher.cpp > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/systemtraytypes.h > PRE-CREATION > > /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/systemtraytypes.cpp > PRE-CREATION > > Diff: http://reviewboard.kde.org/r/3266/diff > > > Testing > ------- > > Tested in plasmaengineexplorer. > > > Thanks, > > Matthieu > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
