Re: Review Request: Fix segmentation fault at plasma_applet_animation_example

2010-01-29 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2738/#review3973 --- Ship it! :)) - Aaron On 2010-01-29 20:25:39, loureiro wrote: > >

Re: Review Request: Fix segmentation fault at plasma_applet_animation_example

2010-01-29 Thread loureiro . andrew
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2738/ --- (Updated 2010-01-29 20:25:39.054487) Review request for Plasma, Aaron Seigo, Mar

Re: Review Request: Fix segmentation fault at plasma_applet_animation_example

2010-01-29 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2738/#review3970 --- will fix this in svn, but good to keep in mind for future :) trunk/K

Re: Review Request: Fix segmentation fault at plasma_applet_animation_example

2010-01-29 Thread igorto
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2738/#review3968 --- Ship it! Ok .. if you implemented all Aaron's requests, you can commi

Re: Review Request: Fix segmentation fault at plasma_applet_animation_example

2010-01-29 Thread loureiro . andrew
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2738/ --- (Updated 2010-01-29 19:32:53.244002) Review request for Plasma, Aaron Seigo, Mar

Re: Review Request: Fix segmentation fault at plasma_applet_animation_example

2010-01-29 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2738/#review3964 --- a good step in the right direction, but the leak is still there and th

Re: Review Request: Fix segmentation fault at plasma_applet_animation_example

2010-01-28 Thread loureiro . andrew
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2738/ --- (Updated 2010-01-28 15:39:43.596354) Review request for Plasma, Aaron Seigo, Mar

Re: Review Request: Fix segmentation fault at plasma_applet_animation_example

2010-01-28 Thread loureiro . andrew
> On 2010-01-27 17:08:08, Aaron Seigo wrote: > > this will result in a leak when the layout isn't assigned. e.g.: > > > > Animation* rotStackedAnim = > > Plasma::Animator::create(Plasma::Animator::RotationStackedAnimation); > > delete rotStackedAnim; > > > > and then we have a leak. >

Re: Review Request: Fix segmentation fault at plasma_applet_animation_example

2010-01-27 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2738/#review3913 --- this will result in a leak when the layout isn't assigned. e.g.:

Re: Review Request: Fix segmentation fault at plasma_applet_animation_example

2010-01-27 Thread André Loureiro
On Wed, Jan 27, 2010 at 10:38 AM, Adenilson Cavalcanti wrote: > Loureiro > > Did you make it sure that there will be not any leak (i.e. running > plasmoidviewer inside of valgrind)? > > Regards Adenilson for sure, here go my heap summary, http://pastebin.com/m2b304044 > > Adenilson > > On Wed, J

Re: Review Request: Fix segmentation fault at plasma_applet_animation_example

2010-01-27 Thread Sebastian Kügler
On Wednesday 27 January 2010 15:38:27 Adenilson Cavalcanti wrote: > Did you make it sure that there will be not any leak (i.e. running > plasmoidviewer inside of valgrind)? That's what he writes, no? :) -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___

Re: Review Request: Fix segmentation fault at plasma_applet_animation_example

2010-01-27 Thread Adenilson Cavalcanti
Loureiro Did you make it sure that there will be not any leak (i.e. running plasmoidviewer inside of valgrind)? Regards Adenilson On Wed, Jan 27, 2010 at 10:35 AM, wrote: > > --- > This is an automatically generated e-mail. To reply, vi