----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2738/ -----------------------------------------------------------
(Updated 2010-01-28 15:39:43.596354) Review request for Plasma, Aaron Seigo, Marco Martin, igorto, and Adenilson Cavalcanti. Changes ------- I updated the diff, now I implement the QObject inheritance on StackedLayout to allow it to use the QWeakPointer and delete it when the RotationStacked dtor is called. Summary ------- This is a small patch that fix a segmentation fault at plasma_applet_animation_example when we close the window. Basically I remove the delete sentence at the RotationStackedAnimation's destruct, I made it because I think when we create a QGraphicsLinearLayout passing a widget that widget will be the owner and responsible to delete it as well its children elements and running the example under valgrind I don't get leaks. Diffs (updated) ----- trunk/KDE/kdelibs/plasma/animations/rotationstacked.cpp 1080090 trunk/KDE/kdelibs/plasma/animations/rotationstacked_p.h 1080090 trunk/KDE/kdelibs/plasma/animations/stackedlayout.h 1080090 trunk/KDE/kdelibs/plasma/animations/stackedlayout.cpp 1080090 Diff: http://reviewboard.kde.org/r/2738/diff Testing ------- Thanks, loureiro _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
