----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2738/#review3964 -----------------------------------------------------------
a good step in the right direction, but the leak is still there and the smart pointer isn't actually being used :) it's all simple to fix, though. with the changes noted below made, this can then be committed to svn (and it should be backported as well) trunk/KDE/kdelibs/plasma/animations/rotationstacked.cpp <http://reviewboard.kde.org/r/2738/#comment3350> should be: delete m_wLayout.data(); trunk/KDE/kdelibs/plasma/animations/rotationstacked.cpp <http://reviewboard.kde.org/r/2738/#comment3347> should be: if (targetWidget() && backWidget && layout) trunk/KDE/kdelibs/plasma/animations/rotationstacked.cpp <http://reviewboard.kde.org/r/2738/#comment3348> probably don't need m_backWidget.data() here, just use backWidget. m_backWidget.data() makes me think we need to check it's value, which we don't :) trunk/KDE/kdelibs/plasma/animations/rotationstacked.cpp <http://reviewboard.kde.org/r/2738/#comment3349> needs: if (!layout) { return; } - Aaron On 2010-01-28 15:39:43, loureiro wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2738/ > ----------------------------------------------------------- > > (Updated 2010-01-28 15:39:43) > > > Review request for Plasma, Aaron Seigo, Marco Martin, igorto, and Adenilson > Cavalcanti. > > > Summary > ------- > > This is a small patch that fix a segmentation fault at > plasma_applet_animation_example when we close the window. > Basically I remove the delete sentence at the RotationStackedAnimation's > destruct, I made it because I think when we create a QGraphicsLinearLayout > passing a widget that widget will be the owner and responsible to delete it > as well its children elements and running the example under valgrind I don't > get leaks. > > > Diffs > ----- > > trunk/KDE/kdelibs/plasma/animations/rotationstacked.cpp 1080090 > trunk/KDE/kdelibs/plasma/animations/rotationstacked_p.h 1080090 > trunk/KDE/kdelibs/plasma/animations/stackedlayout.h 1080090 > trunk/KDE/kdelibs/plasma/animations/stackedlayout.cpp 1080090 > > Diff: http://reviewboard.kde.org/r/2738/diff > > > Testing > ------- > > > Thanks, > > loureiro > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
