On Wed, Jan 27, 2010 at 10:38 AM, Adenilson Cavalcanti <cavalcan...@gmail.com> wrote: > Loureiro > > Did you make it sure that there will be not any leak (i.e. running > plasmoidviewer inside of valgrind)? > > Regards
Adenilson for sure, here go my heap summary, http://pastebin.com/m2b304044 > > Adenilson > > On Wed, Jan 27, 2010 at 10:35 AM, <loureiro.and...@gmail.com> wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviewboard.kde.org/r/2738/ >> ----------------------------------------------------------- >> >> Review request for Plasma, Aaron Seigo, Marco Martin, igorto, and Adenilson >> Cavalcanti. >> >> >> Summary >> ------- >> >> This is a small patch that fix a segmentation fault at >> plasma_applet_animation_example when we close the window. >> Basically I remove the delete sentence at the RotationStackedAnimation's >> destruct, I made it because I think when we create a QGraphicsLinearLayout >> passing a widget that widget will be the owner and responsible to delete it >> as well its children elements and running the example under valgrind I don't >> get leaks. >> >> >> Diffs >> ----- >> >> trunk/KDE/kdelibs/plasma/animations/rotationstacked.cpp 1080090 >> trunk/KDE/kdelibs/plasma/animations/stackedlayout.h 1080090 >> >> Diff: http://reviewboard.kde.org/r/2738/diff >> >> >> Testing >> ------- >> >> >> Thanks, >> >> loureiro >> >> > -- -- André Luiz Viana Loureiro Instituto Nokia de Tecnologia - INdT OpenBossa Labs. - www.openbossa.org _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
