Re: Review Request: Add a tooltip to battery monitor applet

On November 26, 2009, Sebastian Kügler wrote: > Should I commit this one? sure. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digital

Re: Review Request: Add a tooltip to battery monitor applet

On Thursday 26 November 2009 18:01:19 Aaron J. Seigo wrote: > On November 26, 2009, Kåre Särs wrote: > > I also thought about extragear/base/plasma/applets/, but that one is > > empty (dead?). > > anything that you wish to package, ship and support can go into extragear > (and yes, we do need to

Re: Review Request: Add a tooltip to battery monitor applet

On November 26, 2009, Kåre Särs wrote: > I also thought about extragear/base/plasma/applets/, but that one is empty > (dead?). anything that you wish to package, ship and support can go into extragear (and yes, we do need to open a plasma module in extragear again). a forked version won't happen

Re: Review Request: Add a tooltip to battery monitor applet

2009/11/26 Kåre Särs > > > perhaps you could add other statistics n'stuff too, or experiment with > time > > estimation methods... :) > Would that increase the chance of being accepted? > > Okay, so predicting remaining battery time needs artificial intelligence - the research question is to pre

Re: Review Request: Add a tooltip to battery monitor applet

Just do as sebas said. make a hidden option for the current battery plasmoid, this will most probably be accepted. If you are still motivated later, you can write a plasmoid that is dedicated to statistics about the battery. This one too will probably be accepted. The difference is, only a mino

Re: Review Request: Add a tooltip to battery monitor applet

On Thursday 26 November 2009, Chani wrote: > > > > I disagree about the usefulness of time-remaining, but since it is not my > > code I'll let it be. > > > > That said, would I get objections if I would fork "Battery Monitor" into > > a "Battery Time" and then later push it to kdeplasma-addons? >

Re: Review Request: Add a tooltip to battery monitor applet

On November 26, 2009 02:36:22 Sebastian Kügler wrote: > On Thursday 26 November 2009 11:00:17 Kåre Särs wrote: > > That said, would I get objections if I would fork "Battery Monitor" into > > a "Battery Time" and then later push it to kdeplasma-addons? > > I would prefer the hidden config option,

Re: Review Request: Add a tooltip to battery monitor applet

On Thursday 26 November 2009 11:00:17 Kåre Särs wrote: > That said, would I get objections if I would fork "Battery Monitor" into a > "Battery Time" and then later push it to kdeplasma-addons? I would prefer the hidden config option, for the obvious problems that having two copies of the same a

Re: Review Request: Add a tooltip to battery monitor applet

On November 26, 2009 02:00:17 Kåre Särs wrote: > > On 2009-11-25 17:27:53, Cyberbeat wrote: > > > I really like the estimated time. And it really helps. And for not > > > being precise, it is "estimated" :) Would really like to see this in > > > kde-4.4, and perhaps also backported to kde-4.3? > >

Re: Review Request: Add a tooltip to battery monitor applet

> On 2009-11-25 17:27:53, Cyberbeat wrote: > > I really like the estimated time. And it really helps. And for not being > > precise, it is "estimated" :) Would really like to see this in kde-4.4, and > > perhaps also backported to kde-4.3? > > Kåre Särs wrote: > I'm afraid it is a bit too

Re: Review Request: Add a tooltip to battery monitor applet

On Thursday 26 November 2009 08:18:22 Chani Armitage wrote: > as for having a tooltip in the first place... well, my battery plasmoid > just shows the info on hover directly, no need for a tooltip. I have a > large panel, though; does it still do that in small panels? Yep. -- sebas http://www.

Re: Review Request: Add a tooltip to battery monitor applet

> On 2009-11-25 17:27:53, Cyberbeat wrote: > > I really like the estimated time. And it really helps. And for not being > > precise, it is "estimated" :) Would really like to see this in kde-4.4, and > > perhaps also backported to kde-4.3? > > Kåre Särs wrote: > I'm afraid it is a bit too

Re: Review Request: Add a tooltip to battery monitor applet

> On 2009-11-25 18:37:46, Andrew Coles wrote: > > Proof-reading: > > > > 1) Change 'Estimated time remaining %1' to 'Estimated time remaining: %1'. > > The other items in the tool-tip separate the label from the data using a > > colon (e.g. Charging: 20% charged), so the time remaining needs

Re: Review Request: Add a tooltip to battery monitor applet

> On 2009-11-25 18:37:46, Andrew Coles wrote: > > Proof-reading: > > > > 1) Change 'Estimated time remaining %1' to 'Estimated time remaining: %1'. > > The other items in the tool-tip separate the label from the data using a > > colon (e.g. Charging: 20% charged), so the time remaining needs

Re: Review Request: Add a tooltip to battery monitor applet

> On 2009-11-25 17:27:53, Cyberbeat wrote: > > I really like the estimated time. And it really helps. And for not being > > precise, it is "estimated" :) Would really like to see this in kde-4.4, and > > perhaps also backported to kde-4.3? I'm afraid it is a bit too late for KDE 4.4 with the h

Re: Review Request: Add a tooltip to battery monitor applet

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2010/#review3276 --- Proof-reading: 1) Change 'Estimated time remaining %1' to 'Estimated

Re: Review Request: Add a tooltip to battery monitor applet

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2010/#review3267 --- I really like the estimated time. And it really helps. And for not bei

Re: Review Request: Add a tooltip to battery monitor applet

On Sunday 01 November 2009 10:34:16 Kåre Särs wrote: > I'm not running trunk, so I had to comment out the setStatus() functions > (not done in the patch). If you're not, you patch is likely to not apply. I've been re-working the layout of the popup dialog, but I'm not finished with it yet. --

Re: Review Request: Add a tooltip to battery monitor applet

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2010/ --- (Updated 2009-11-01 09:34:16.376436) Review request for Plasma. Changes --

Re: Review Request: Add a tooltip to battery monitor applet

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2010/ --- (Updated 2009-11-01 08:04:09.930792) Review request for Plasma. Changes --

Re: Review Request: Add a tooltip to battery monitor applet

On October 30, 2009 18:24:03 Aaron J. Seigo wrote: > On October 30, 2009, Chani wrote: > > percentages are the bogus number :P it's like giving a latitude and > > longitude instead of a street address. > > except my street address doesn't change just because i drive there in a car > instead of wa

Re: Review Request: Add a tooltip to battery monitor applet

On October 30, 2009, Chani wrote: > percentages are the bogus number :P it's like giving a latitude and > longitude instead of a street address. except my street address doesn't change just because i drive there in a car instead of walk. a more accurate analogy would be offering a travel time (

Re: Review Request: Add a tooltip to battery monitor applet

> > On 2009-10-29 20:55:56, Aaron Seigo wrote: > > > trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp, > > > line 1123 > > > > >> > > > > > > we don't show time remaining; it's a bogus number. perc

Re: Review Request: Add a tooltip to battery monitor applet

> On 2009-10-29 20:55:56, Aaron Seigo wrote: > > trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp, > > line 63 > > > > > > interestingly, you don't need to include this one as ToolTipManager > > dra

Re: Review Request: Add a tooltip to battery monitor applet

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2010/#review2854 --- a few bits of clean up, but a tooltip is a good idea here. trunk/KDE