> On 2009-11-25 18:37:46, Andrew Coles wrote:
> > Proof-reading:
> >
> > 1) Change 'Estimated time remaining %1' to 'Estimated time remaining: %1'.
> > The other items in the tool-tip separate the label from the data using a
> > colon (e.g. Charging: 20% charged), so the time remaining needs to do so
> > too for consistency.
> >
> > 2) In the case of less than an hour of battery life left, I'd recommend:
> >
> > content += i18np("Estimated time remaining: 1 minute", "Estimated
> > time remaining: %1 minutes", m_minutes);
> >
> > ...as this is clearer than, say, "Estimated time remaining: 0:22".
Those are good points. Lets see if the patch gets support. If it gets the
support I'll make a new patch with those changes.
- Kåre
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2010/#review3276
-----------------------------------------------------------
On 2009-11-01 09:34:16, Kåre Särs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2010/
> -----------------------------------------------------------
>
> (Updated 2009-11-01 09:34:16)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This path adds a tool-tip for the battery-monitor applet. The tool-tip
> contains charge percentage and estimated time left.
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.h
> 1041319
> trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp
> 1041319
>
> Diff: http://reviewboard.kde.org/r/2010/diff
>
>
> Testing
> -------
>
> I'm not running trunk, so I had to comment out the setStatus() functions (not
> done in the patch).
>
>
> Thanks,
>
> Kåre
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
