> On 2009-11-25 17:27:53, Cyberbeat wrote: > > I really like the estimated time. And it really helps. And for not being > > precise, it is "estimated" :) Would really like to see this in kde-4.4, and > > perhaps also backported to kde-4.3? > > Kåre Särs wrote: > I'm afraid it is a bit too late for KDE 4.4 with the hard freeze in just > a couple of hours, and I have not gotten a "ship it".... > > Chani Armitage wrote: > there wasn't a "ship it" because it turned into a "fork it in > playground". for the time-remaining part at least. > > as for having a tooltip in the first place... well, my battery plasmoid > just shows the info on hover directly, no need for a tooltip. I have a large > panel, though; does it still do that in small panels?
I wanted to add the tool-tip to add the time-remaining part without touching the hover info. As the time-remaining was not wanted I'm not sure either if there is a need for a popup that does not give any extra information. I disagree about the usefulness of time-remaining, but since it is not my code I'll let it be. That said, would I get objections if I would fork "Battery Monitor" into a "Battery Time" and then later push it to kdeplasma-addons? - Kåre ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2010/#review3267 ----------------------------------------------------------- On 2009-11-01 09:34:16, Kåre Särs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2010/ > ----------------------------------------------------------- > > (Updated 2009-11-01 09:34:16) > > > Review request for Plasma. > > > Summary > ------- > > This path adds a tool-tip for the battery-monitor applet. The tool-tip > contains charge percentage and estimated time left. > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.h > 1041319 > trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp > 1041319 > > Diff: http://reviewboard.kde.org/r/2010/diff > > > Testing > ------- > > I'm not running trunk, so I had to comment out the setStatus() functions (not > done in the patch). > > > Thanks, > > Kåre > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
