----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2010/#review2854 -----------------------------------------------------------
a few bits of clean up, but a tooltip is a good idea here. trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/CMakeLists.txt <http://reviewboard.kde.org/r/2010/#comment2222> this shouldn't be committed to svn (though i see why you added it for your own needs :) trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp <http://reviewboard.kde.org/r/2010/#comment2223> interestingly, you don't need to include this one as ToolTipManager drags it in for us. not a big deal at all, just a perhaps-interesting note :) trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp <http://reviewboard.kde.org/r/2010/#comment2224> i believe for translation purposes, this should be all on the same line and shouldn't be using arg() either, e.g.: if (status == "Discharging") { content += i18n("Discharging: %1 charged", battery_charge); } else { content += i18n("Charging: %1 charged", battery_charge); } content.append("<br>"); // keep that out of the i18n trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp <http://reviewboard.kde.org/r/2010/#comment2225> we don't show time remaining; it's a bogus number. - Aaron On 2009-10-29 20:26:00, Kåre Särs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2010/ > ----------------------------------------------------------- > > (Updated 2009-10-29 20:26:00) > > > Review request for Plasma. > > > Summary > ------- > > This path adds a tool-tip for the battery-monitor applet. The tool-tip > contains charge percentage and estimated time left. The patch also changes > the CMakeLists.txt to make it possible to compile the applet standalone. > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/CMakeLists.txt > 1041319 > trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.h > 1041319 > trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp > 1041319 > > Diff: http://reviewboard.kde.org/r/2010/diff > > > Testing > ------- > > I'm not running trunk, so I had to comment out the setStatus() functions (not > done in the patch). > > > Thanks, > > Kåre > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
