D18890: Add button to reset index database and repair Baloo crashing

ngraham added a comment. I'd like to revisit this. Can we get back to it and fix the outstanding issues? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18890 To: guoyunhe, #plasma, #baloo Cc: mart, davidedmundson, bruns, ngraham, plasma-devel, LeGast00n, jra

D18890: Add button to reset index database and repair Baloo crashing

bruns added a comment. In D18890#410137 , @davidedmundson wrote: > If we know the DB is corrupted, and it's just a cache, why do we need a user facing button? There are many possible ways of corruption: - non-decodable values - en

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe added a comment. In D18890#419886 , @mart wrote: > In D18890#410144 , @guoyunhe wrote: > > > In D18890#410137 , @davidedmundson wrote: > > > >

D18890: Add button to reset index database and repair Baloo crashing

mart added a comment. In D18890#410144 , @guoyunhe wrote: > In D18890#410137 , @davidedmundson wrote: > > > If we know the DB is corrupted, and it's just a cache, why do we need a user facing button

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe added a comment. In D18890#410137 , @davidedmundson wrote: > If we know the DB is corrupted, and it's just a cache, why do we need a user facing button? It is also possible to move this function to database corruption handler. O

D18890: Add button to reset index database and repair Baloo crashing

davidedmundson added a comment. If we know the DB is corrupted, and it's just a cache, why do we need a user facing button? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18890 To: guoyunhe, #plasma, #baloo Cc: davidedmundson, bruns, ngraham, plasma-devel, j

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe added inline comments. INLINE COMMENTS > bruns wrote in kcm.cpp:197 > IMHO this whole block should be a single, blocking command in balooctl, i.e. > move the whole logic to balooctl. Will try. > bruns wrote in kcm.cpp:210 > Care to elaborate? If I run "balooctl start" in QProcess, ba

D18890: Add button to reset index database and repair Baloo crashing

bruns added inline comments. INLINE COMMENTS > kcm.cpp:197 > +const QString rm = QStandardPaths::findExecutable(QStringLiteral("rm")); > +const QString balooctl = > QStandardPaths::findExecutable(QStringLiteral("balooctl")); > +const QString baloofile = > QStandardPaths::findExecuta

D18890: Add button to reset index database and repair Baloo crashing

ngraham added a comment. No, I don't want a dialog window of any kind. Just a spinner on the page that says, "Indexing is in progress" or something was what I had in mind. An inline KMessageWidget is okay too. However my major concern was communicating to the user that something happened so

D18890: Add button to reset index database and repair Baloo crashing

bruns added a comment. In D18890#409359 , @ngraham wrote: > Thanks! This is pretty good as-is, and I can confirm that it works just fine. However once the user presses the button, there's no further feedback, which could encourage them to repeat

D18890: Add button to reset index database and repair Baloo crashing

ngraham added a comment. Thanks! 1. Could we use an inline `KMessageWidget` instead of a dialog box? Dialog boxes are annoying. 2. The text should be something more like "Database is now being rebuilt", since if I'm understanding the code, it will be displayed immediately. So it isn't

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe updated this revision to Diff 51436. guoyunhe added a comment. - Make message box translatable REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18890?vs=51435&id=51436 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18890 AFF

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe added a comment. Screenshot: F6608381: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18890 To: guoyunhe, #plasma, #baloo Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ashaposhnikov, as

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe updated this revision to Diff 51435. guoyunhe added a comment. - Add message box for Rebuild Index Database button REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18890?vs=51325&id=51435 BRANCH master REVISION DETAIL https://phabricator

D18890: Add button to reset index database and repair Baloo crashing

ngraham added a comment. Thanks! This is pretty good as-is, and I can confirm that it works just fine. However once the user presses the button, there's no further feedback, which could encourage them to repeatedly press it again--not a good idea. Maybe while the initial index is being gener

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe added a comment. In D18890#409270 , @ngraham wrote: > Great! Just one more UI suggestion: use the string "Rebuild Index Database" Updated :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18890

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe updated this revision to Diff 51325. guoyunhe added a comment. - Reset index database button align right REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18890?vs=51324&id=51325 BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D18890: Add button to reset index database and repair Baloo crashing

ngraham added a comment. Great! Just one more UI suggestion: use the string "Rebuild Index Database" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18890 To: guoyunhe, #plasma, #baloo Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ashaposhnikov,

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe added a comment. In D18890#409258 , @ngraham wrote: > I wish this weren't necessary, but I think it's a good idea for the time being. > > Can you reduce the button width so it doesn't span the entire layout? It should be as small as

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe updated this revision to Diff 51324. guoyunhe added a comment. - Reset index database button align right REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18890?vs=51294&id=51324 BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D18890: Add button to reset index database and repair Baloo crashing

ngraham added a comment. I wish this weren't necessary, but I think it's a good idea for the time being. Can you reduce the button width so it doesn't span the entire layout? It should be as small as possible and right-aligned. REPOSITORY R119 Plasma Desktop REVISION DETAIL https:/

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Here are a lot of bug reports of Baloo crashing caused by corrupted database. This patch provide a button in KCM to quickly dele