ngraham added a comment.

  Thanks! This is pretty good as-is, and I can confirm that it works just fine. 
However once the user presses the button, there's no further feedback, which 
could encourage them to repeatedly press it again--not a good idea. Maybe while 
the initial index is being generated, we could display a progress spinner (and 
a label too) and disable the button. What do you think?

INLINE COMMENTS

> kcm.cpp:208
> +    proc->start(balooctl, args3);
> +    proc->waitForFinished();
> +}

This whole section could benefit from a few more line breaks to separate the 
commands into logical groups.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18890

To: guoyunhe, #plasma, #baloo
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ashaposhnikov, 
astippich, spoorun, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
abrahams, sebas, apol, mart

Reply via email to