Re: Switches around the world and broken metaphors [Was: Battery Monitor revamp]

2013-07-03 Thread Mario Fux KDE ML
Am Sonntag 26 Mai 2013, 18.07:14 schrieb Thomas Pfeiffer: Morning Added the below content to a new page about Repeated Discussions in Plasma: http://community.kde.org/Plasma/RepeatedDiscussions/SwitchesVsCheckboxes Hope that's ok. Thx Mario > On Sunday 26 May 2013 00:05:56 Marco Martin wrote:

Re: Battery Monitor revamp

2013-06-03 Thread Aaron J. Seigo
On Monday, June 3, 2013 18:16:12 Kai Uwe Broulik wrote: > Is there anything else that needs to be addressed? Would love to merge that > code once the remaining dependencies (Review 110607, Review 110608) are > commented on and commited. assuming the layout issues are tidied up, i'd like to see thi

Re: Battery Monitor revamp

2013-06-03 Thread Kai Uwe Broulik
Is there anything else that needs to be addressed? Would love to merge that code once the remaining dependencies (Review 110607, Review 110608) are commented on and commited. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailma

Re: Battery Monitor revamp

2013-05-30 Thread Aaron J. Seigo
On Thursday, May 30, 2013 16:51:16 Kai Uwe Broulik wrote: > Is the graphic ok that way? Dunno what I could do about the other issue you > mentioned but it has been that for years now and doesn't really matter at > the usual size. it's not a requirement, just a nice to have. i do notice it at usual

Re: Battery Monitor revamp

2013-05-30 Thread Kai Uwe Broulik
Is the graphic ok that way? Dunno what I could do about the other issue you mentioned but it has been that for years now and doesn't really matter at the usual size. What's missing now before the battery monitor can go into master? - Discussion about remaining time. The strings are in place, th

Re: Battery Monitor revamp

2013-05-28 Thread Martin Klapetek
On 5/28/13, Thomas Pfeiffer wrote: > On 28.05.2013 12:04, Àlex Fiestas wrote: >> For what is worth (and from the Solid side of things). >> >> Batteries have improved a lot since last time we discussed this issue, >> back on the days a high CPU round of 10min would drain huge percentage >> of the p

Re: Battery Monitor revamp

2013-05-28 Thread Kai Uwe Broulik
> * the bottom of the inner rect of the battery is a slightly different colour > from all the other borders. it is slightly darker. That's in the current version too and is because the meter elements themselves have a dark bottom border. Was a trivial fix though. > * the inner rect cuts off right

Re: Battery Monitor revamp

2013-05-28 Thread Thomas Pfeiffer
On 28.05.2013 12:04, Àlex Fiestas wrote: For what is worth (and from the Solid side of things). Batteries have improved a lot since last time we discussed this issue, back on the days a high CPU round of 10min would drain huge percentage of the power in your battery, hence the estimation was rea

Re: Battery Monitor revamp

2013-05-28 Thread Kai Uwe Broulik
Just committed patch to the battery monitor. Tested with both the current blocky battery.svgz and my new one. Magic! Attached is the new battery.svgz which belongs into kde-runtime. And obligatory screenshots [1] Have a try. Comments? [1] http://privat.broulik.de/batterypercentagemoreaccurate2.

Re: Battery Monitor revamp

2013-05-28 Thread Àlex Fiestas
For what is worth (and from the Solid side of things). Batteries have improved a lot since last time we discussed this issue, back on the days a high CPU round of 10min would drain huge percentage of the power in your battery, hence the estimation was really bad. Additionally the estimation was do

Re: Battery Monitor revamp

2013-05-28 Thread Aaron J. Seigo
On Tuesday, May 28, 2013 11:09:57 Kai Uwe Broulik wrote: > > So I'm a +1 for this change. It will need to be kept backwards compat for > > other themes in the code, but that's not hard to do. > > if (fillElementSvg.hasElement("Fill10")) { > // use new more accurate method > } else { > // fallb

Re: Battery Monitor revamp

2013-05-28 Thread Kai Uwe Broulik
> So I'm a +1 for this change. It will need to be kept backwards compat for > other themes in the code, but that's not hard to do. if (fillElementSvg.hasElement("Fill10")) { // use new more accurate method } else { // fallback for other/older themes } would be the approach for this, right? >

Re: Battery Monitor revamp

2013-05-28 Thread Aaron J. Seigo
On Monday, May 27, 2013 11:13:40 Dario Freddi wrote: > Such a choice has only one possible outcome: distributions and users > patching the plasmoid for restoring the functionality, hidden or not, > resulting in harder bug triaging and higher chances for breakage. the hostage situation. no thanks.

Re: Battery Monitor revamp

2013-05-28 Thread Aaron J. Seigo
On Monday, May 27, 2013 11:34:38 Kai Uwe Broulik wrote: > Am Montag, 27. Mai 2013, 10:53:58 schrieb Kai Uwe Broulik: > > I'd be fine with dropping the overlay if we had 10 linear steps for > > the icon rather than 5 which are unequally distributed. > > I did a few changes to the battery.svgz for t

Re: Battery Monitor revamp

2013-05-27 Thread Dario Freddi
2013/5/27 Kai Uwe Broulik > I could add it to the expandable battery details but it will show the > overall remaining time for all batteries in contrast to the other > properties which are directly related to the battery they emerge from. > Actually I don't care. I don't have a strong opinion on

Re: Battery Monitor revamp

2013-05-27 Thread Kai Uwe Broulik
Am Montag, 27. Mai 2013, 10:53:58 schrieb Kai Uwe Broulik: > I'd be fine with dropping the overlay if we had 10 linear steps for > the icon rather than 5 which are unequally distributed. I did a few changes to the battery.svgz for the air theme. What do you think? Now we can have 10 equal steps (t

Re: Battery Monitor revamp

2013-05-27 Thread Kai Uwe Broulik
I could add it to the expandable battery details but it will show the overall remaining time for all batteries in contrast to the other properties which are directly related to the battery they emerge from. Actually I don't care. I don't have a strong opinion on whether to show it or not. Would

Re: Battery Monitor revamp

2013-05-27 Thread Dario Freddi
2013/5/24 > What's missing: > - Remaining time. There is no "global" category anymore and since we > discourage and removed the option for displaying remaining time, I didn't > see the need to implement it in solod so we can show it in eg. the battery > advanced properties > > I promised to neve

Re: Battery Monitor revamp

2013-05-27 Thread Kai Uwe Broulik
I feel better when I see it more accurately. My experience shows that battery icons are usually way too pessimistic or way too optimistic. Now it shows two of five bars although the battery is still half full. And once it goes 20% or below it is red although 20% means half an hour of battery life

Re: Battery Monitor revamp

2013-05-27 Thread Aaron J. Seigo
On Sunday, May 26, 2013 18:53:24 Kai Uwe Broulik wrote: > On the desktop it would work that way, yes. But I really want to have the > percentage shown in the panel but don't know how that could work better like out of curiosity: what is the value of having the exact % always shown in the main UI?

Re: Battery Monitor revamp

2013-05-26 Thread Marco Martin
On Sunday 26 May 2013 18:53:24 Kai Uwe Broulik wrote: > > very nice; one thing that Marco noted was that it should only be animating > > when the popup is open > > Fixed. Although I couldnt just do > running: plasmoid.popupShowing > but had to fetch the property on the root item and pass it thro

Re: Switches around the world and broken metaphors [Was: Battery Monitor revamp]

2013-05-26 Thread Thomas Pfeiffer
On Sunday 26 May 2013 18:35:20 Martin Graesslin wrote: > > So if ambiguity is the only reason against using switches on Desktop, we > > should use them. > > At least for me there is another reason: given the way how the switch > component is designed (again no matter which one) I am inclined to dr

Re: Battery Monitor revamp

2013-05-26 Thread Kai Uwe Broulik
So I pushed a few patches: Am Samstag, 25. Mai 2013, 13:10:14 schrieb Aaron J. Seigo: > see these screenshots for some layouting issues: Fixed. > also, after expanding a battery to see detailed information, collapsing it > leaves an empty space. that should re-collapse, similar to thow the > not

Re: Switches around the world and broken metaphors [Was: Battery Monitor revamp]

2013-05-26 Thread Martin Graesslin
On Sunday 26 May 2013 18:07:14 Thomas Pfeiffer wrote: > On Sunday 26 May 2013 00:05:56 Marco Martin wrote: > > On Saturday 25 May 2013 14:32:29 Martin Graesslin wrote: > > > > And this is clearly the case let's work around something we don't want > > > > to > > > > fix. Switches are a clear improve

Re: Switches around the world and broken metaphors [Was: Battery Monitor revamp]

2013-05-26 Thread Thomas Pfeiffer
On Sunday 26 May 2013 00:05:56 Marco Martin wrote: > On Saturday 25 May 2013 14:32:29 Martin Graesslin wrote: > > > And this is clearly the case let's work around something we don't want > > > to > > > fix. Switches are a clear improvement over checkboxes depending on the > > > context even my 60yo

Re: Switches around the world and broken metaphors [Was: Battery Monitor revamp]

2013-05-25 Thread Marco Martin
On Saturday 25 May 2013 14:32:29 Martin Graesslin wrote: > > And this is clearly the case let's work around something we don't want to > > fix. Switches are a clear improvement over checkboxes depending on the > > context even my 60yo mom got it much quickier than a checkbox would be > > able > > t

Re: Switches around the world and broken metaphors [Was: Battery Monitor revamp]

2013-05-25 Thread Martin Graesslin
On Saturday 25 May 2013 09:43:26 Daniel Nicoletti wrote: > 2013/5/25 Martin Graesslin : > > And I would completely fail to use the switch. I have huge problems > > understanding those switches and I have not seen any implementation of the > > switch where I got which one is on and which one is off.

Re: Switches around the world and broken metaphors [Was: Battery Monitor revamp]

2013-05-25 Thread Daniel Nicoletti
2013/5/25 Martin Graesslin : > And I would completely fail to use the switch. I have huge problems > understanding those switches and I have not seen any implementation of the > switch where I got which one is on and which one is off. You are totally right, because they need fixing, even if they a

Re: Switches around the world and broken metaphors [Was: Battery Monitor revamp]

2013-05-25 Thread Martin Graesslin
On Saturday 25 May 2013 09:14:03 Daniel Nicoletti wrote: > 2013/5/25 Aaron J. Seigo : > > Switches are not to be used on Desktop. For 4.11 the QML switch component > > appears as a checkbox, so you really don't have a choice in the end. The > > reasons are: > > > > * consistency > > * input device

Re: Battery Monitor revamp

2013-05-25 Thread Daniel Nicoletti
2013/5/25 Aaron J. Seigo : > Switches are not to be used on Desktop. For 4.11 the QML switch component > appears as a checkbox, so you really don't have a choice in the end. The > reasons are: > > * consistency > * input device appropriateness > * people use them poorly on desktop (just look at UIs

Re: Battery Monitor revamp

2013-05-25 Thread Kai Uwe Broulik
Hi, > tried it out and Marco (who is visiting for a few days) and i looked it > over. see these screenshots for some layouting issues: I didn't see those at first because I am using bigger icon sizes and bigger font sizes. I guess using Math.max(48, iconSizes.dialog) would fix that? 48 is the ico

Re: Battery Monitor revamp

2013-05-25 Thread Aaron J. Seigo
On Friday, May 24, 2013 10:05:35 k...@privat.broulik.de wrote: > A screenshot can be found here: > http://privat.broulik.de/batterymonitornew1.png tried it out and Marco (who is visiting for a few days) and i looked it over. see these screenshots for some layouting issues: http://wstaw.org/m/201

Re: Battery Monitor revamp

2013-05-24 Thread Kai Uwe Broulik
Hi. > Oh noes! Please restore this option since it is crucial There's been a huge argument about that on BKO and decision from maintainers was to only have a hidden option for that. I personally would also want to have it. I'm just not sure where to put it. Having a global item in the list just

Re: Battery Monitor revamp

2013-05-24 Thread Andreas Demmer
Hi! > as some have already seen on my G+ page, I'm currently doing a > complete UX revamp of the battery monitor plasmoid. Great work, looks really stunning! :-) > What's missing: > - Remaining time. There is no "global" category anymore and since we > discourage and removed the option fo

Battery Monitor revamp

2013-05-24 Thread kde
Hi there, as some have already seen on my G+ page, I'm currently doing a complete UX revamp of the battery monitor plasmoid. I have pushed my changes into the plasma/broulik/batterymonitor branch of kde-workspace. It requires recentmost kdelibs and Review Request 110607. A screenshot can