D25019: Ensure that GlobalDrawer topContent always stays on top

2019-11-05 Thread Wolfgang Bauer
wbauer added a comment. In D25019#558919 , @mart wrote: > Unfortunately, it has been pushed too near to framework release, so now it has been released, breaking several apps for a whole framework release. It has only been tagged so far, i

D24126: [GTK3] CSD windows show handles on .solid-csd

2019-10-30 Thread Wolfgang Bauer
wbauer added a comment. FTR, we got a downstream bug report about this for openSUSE Leap 15.1 (which ships Plasma 5.12 LTS): https://bugzilla.opensuse.org/show_bug.cgi?id=1155387 That's mainly why I asked... ;-) REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde

D24126: [GTK3] CSD windows show handles on .solid-csd

2019-10-30 Thread Wolfgang Bauer
wbauer added a comment. In D24126#556709 , @ngraham wrote: > Doubtful; it relies on the scss rewrite which happened in 5.15 or 5.16 IIRC. Indeed, 5.12 didn't use scss yet to generate gtk.css, but contains the gtk.css in the first place.

D24126: [GTK3] CSD windows show handles on .solid-csd

2019-10-30 Thread Wolfgang Bauer
wbauer added a comment. Could this be backported to 5.12 too maybe? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24126 To: cblack, #breeze, ngraham, ndavis Cc: wbauer, ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D24996: Create directory when saving the menu file

2019-10-28 Thread Wolfgang Bauer
This revision was automatically updated to reflect the committed changes. Closed by commit R103:d7dbd84e96b8: Create directory when saving the menu file (authored by wbauer). REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24996?vs=68865&id=68869 REVISION

D24996: Create directory when saving the menu file

2019-10-28 Thread Wolfgang Bauer
wbauer added a comment. Alternatively, the directory could also be created in `TreeView::TreeView()`, but I think this place is more logical (and it would also work if `MenuFile` would be used in other places as well). REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde

D24996: Create directory when saving the menu file

2019-10-28 Thread Wolfgang Bauer
wbauer created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. wbauer requested review of this revision. REVISION SUMMARY Commit 0bf70655 ported kmenuedit away from KStandardDirs

D24748: [containmentlayoutmanager] Don't accept button events that only start timers

2019-10-24 Thread Wolfgang Bauer
wbauer added a comment. In D24748#552313 , @anthonyfieroni wrote: > You can try it like that: > > if (!m_editMode) { > event->setAccepted(false); > } > > > or > > event->setAccepted(m_editMode); > That does

D24748: [containmentlayoutmanager] Don't accept button events that only start timers

2019-10-22 Thread Wolfgang Bauer
wbauer added a comment. One thing maybe: with the Desktop layout, if you switch an applet to edit mode (by pressing and holding the left mouse button), it's not possible to exit edit mode by left-clicking on the desktop (even if no left-click action is configured). You need to click on a dif

D24748: [containmentlayoutmanager] Don't accept button events that only start timers

2019-10-19 Thread Wolfgang Bauer
wbauer added a comment. The patch fixes the problem here, and I didn't notice regressions either so far. I only did a quick test though, and cannot really comment on the patch per se. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24748 To: davidedmundso

D23542: Promote KCM to top level and rename accordingly

2019-09-03 Thread Wolfgang Bauer
wbauer added a comment. In D23542#521296 , @nicolasfella wrote: > Please note that k3b ships the 'CDDB retrieval' KCM, which is in the Multimedia section as well That's actually part of libkcddb and not k3b, btw. And there's also au

D22814: Remove colon (:) prefix when looking up dictionary word

2019-08-07 Thread Wolfgang Bauer
wbauer added a comment. Thank you! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22814 To: broulik, #plasma, mart, kossebau, davidedmundson Cc: wbauer, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-

D22814: Remove colon (:) prefix when looking up dictionary word

2019-08-06 Thread Wolfgang Bauer
wbauer added a comment. Can this be pushed to the 5.12 branch as well, please? It's broken in 5.12.8 as well (https://bugs.kde.org/390776 was actually reported against 5.12.1), the patch applies cleanly and does fix the problem. REPOSITORY R114 Plasma Addons REVISION DETAIL https://pha

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

2019-07-20 Thread Wolfgang Bauer
wbauer added a comment. What about the stable 5.16 branch? It has only be committed to master so far AFAICS, so the fix would only end up in Plasma 5.17 which is still 3 months away... REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #fr

D17187: Set the default cursor theme to breeze_cursors

2019-04-05 Thread Wolfgang Bauer
wbauer added a comment. I just noticed that this change is missing again in 5.15. Apparently it was reverted (by mistake?) in R98:e1f97ce5 ... REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kd

D17187: Set the default cursor theme to breeze_cursors

2018-11-28 Thread Wolfgang Bauer
wbauer added a comment. Btw, It seems the gtk-cursor-theme-name option actually has no influence on GTK2 applications, so it probably wouldn't need to be written to the GTK2 config here. But then, the KCM does save it to the GTK2 config as well... REPOSITORY R98 Breeze for Gtk REVISION

D17187: Set the default cursor theme to breeze_cursors

2018-11-28 Thread Wolfgang Bauer
wbauer added a comment. In D17187#367366 , @fvogt wrote: > > The same happens already if one uses the GTK KCM though, as it will always write a cursor theme entry too. > > Yes, that can be unexpected - even by not changing the cursor theme e

D17187: Set the default cursor theme to breeze_cursors

2018-11-28 Thread Wolfgang Bauer
wbauer added a comment. In D17187#367565 , @ngraham wrote: > That's a pre-existing bug: https://bugs.kde.org/show_bug.cgi?id=401507 That's not the full truth though. The cursor theme KCM will affect the default theme of the whole session

D17187: Set the default cursor theme to breeze_cursors

2018-11-28 Thread Wolfgang Bauer
wbauer added a comment. In D17187#367118 , @fvogt wrote: > In D17187#367110 , @wbauer wrote: > > > Actually, if the cursor theme is not set to anything, GTK would just use the session's default. I.e.

D17187: Set the default cursor theme to breeze_cursors

2018-11-27 Thread Wolfgang Bauer
wbauer added a comment. Actually, if the cursor theme is not set to anything, GTK would just use the session's default. And that's how it should be IMHO. But at least in openSUSE, the cursor theme is explicitly set to Adwaita in the system-wide GTK config, /etc/gtk-3.0/settings.ini . REPOS

D15598: Sort icon and cursor themes case-insensitively

2018-09-24 Thread Wolfgang Bauer
wbauer added a comment. In D15598#328967 , @ngraham wrote: > Darn, looks like arc didn't notice my rebase on 5.14. Oh well, I guess this'll go into 5.15. Well, you could cherry-pick it into the 5.14 branch (using `git cherry-pick xxx`).

D15598: Sort icon and cursor themes case-insensitively

2018-09-20 Thread Wolfgang Bauer
wbauer added a comment. Works (and looks) fine for me now. Btw, it wouldn't really be necessary to call `setSortRole(Qt::DisplayRole)`, as the default value is `Qt::DisplayRole` anyway. (but of course doing it is not wrong either...) REPOSITORY R99 KDE Gtk Configuration Tool BRANCH

D15598: Sort icon and cursor themes case-insensitively

2018-09-20 Thread Wolfgang Bauer
wbauer added a comment. In D15598#328791 , @broulik wrote: > > Although, I think that would need to be done every time the data changes. > > `QSortFilterProxyModel` does that automatically You mean it will keep the data sorted after ch

D15598: Sort icon and cursor themes case-insensitively

2018-09-20 Thread Wolfgang Bauer
wbauer added a comment. In D15598#328747 , @wbauer wrote: > I suppose that's because, according to the QSortFilterProxyModel docs, `At this point, neither sorting nor filtering is enabled; the original data is displayed in the view.` > Appare

D15598: Sort icon and cursor themes case-insensitively

2018-09-20 Thread Wolfgang Bauer
wbauer added a comment. Well, I tried this patch (applied upon 4.13.90a) and it doesn't seem to change anything. I still get icon and cursor themes starting with a lower-case character sorted after all those with an upper-case character. I suppose that's because, according to the QSort

D14863: [kconf_update] Add "gtk-primary-button-warps-slider=0" to generated GTK3 config

2018-08-15 Thread Wolfgang Bauer
This revision was automatically updated to reflect the committed changes. Closed by commit R98:f5121ba89abf: [kconf_update] Add "gtk-primary-button-warps-slider=0" to generated GTK3 config (authored by wbauer). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.

D14863: [kconf_update] Add "gtk-primary-button-warps-slider=0" to generated GTK3 config

2018-08-15 Thread Wolfgang Bauer
wbauer created this revision. wbauer added reviewers: Breeze, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. wbauer requested review of this revision. REVISION SUMMARY This brings the default GTK3 settings more in line with Qt's behavior, and it's also the defa

D14493: fontinst quits after KJob is done

2018-07-31 Thread Wolfgang Bauer
wbauer added a comment. Wouldn't it make sense to push this to the 5.12 and 5.13 branches as well? After all, there are quite a lot of bug reports about this... Should be answered by some Plasma developer though, I suppose. ;-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https:/

D14493: fontinst quits after KJob is done

2018-07-31 Thread Wolfgang Bauer
wbauer added a comment. I can confirm that this patch does fix the problem with installing several fonts at once systemwide here. And fontinst still exits after some time of idleness. Btw, there's also BUG:349673 about the same problem. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13586: Ref KConfig whilst we're using it

2018-06-19 Thread Wolfgang Bauer
wbauer added a comment. In D13586#279538 , @fvogt wrote: > In D13586#279514 , @ngraham wrote: > > > Could this have any relationship to https://bugs.kde.org/show_bug.cgi?id=395401? > > > In th

D12606: Use QUrl::fromUserInput to construct sound url

2018-04-30 Thread Wolfgang Bauer
wbauer added a comment. In D12606#255923 , @davidedmundson wrote: > It is not "dead" however it is now restricted to fixes for major bugs such as security and data loss. Ok, I don't think this qualifies then... REPOSITORY R120 Plasma

D12606: Use QUrl::fromUserInput to construct sound url

2018-04-30 Thread Wolfgang Bauer
wbauer added a comment. Forgot to ask: should I cherry-pick this to the 5.8 branch too? Or is that completely dead already anyway? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12606 To: wbauer, #plasma, davidedmundson Cc: ngraham, plasma-devel, ragreen,

D12606: Use QUrl::fromUserInput to construct sound url

2018-04-30 Thread Wolfgang Bauer
This revision was automatically updated to reflect the committed changes. Closed by commit R120:608204765110: [ksmserver] Use QUrl::fromUserInput to construct sound url (authored by wbauer). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12606?vs=3330

D12606: Use QUrl::fromUserInput to construct sound url

2018-04-29 Thread Wolfgang Bauer
wbauer created this revision. wbauer added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. wbauer requested review of this revision. REVISION SUMMARY Since Phonon 4.9, this code fails to play a login sound if the sound

D12476: kcm_opengl: Fix retrieval of DRI information

2018-04-24 Thread Wolfgang Bauer
wbauer added a comment. I gave the patch a try (openSUSE Leap 42.3 with kernel 4.4). The 3D accelerator info is displayed again now (as with kernel < 3.12), but it shows "drm" as kernel module instead of "radeon" as I would expect. INLINE COMMENTS > opengl.cpp:211 > +dri_info.pci =

D10495: Workaround to restore KF5 programs from system tray

2018-02-13 Thread Wolfgang Bauer
wbauer added a subscriber: KWin. wbauer added a comment. Indeed. One thing that started this is https://bugs.kde.org/show_bug.cgi?id=389663 I do think this should be fixed on the lower level if possible. Adding KWin as subscriber as well to hopefully get most people that have more

D6389: [xembedsniproxy] Free windowAttributes in every case

2017-06-26 Thread Wolfgang Bauer
This revision was automatically updated to reflect the committed changes. Closed by commit R120:d45584d1de4f: [xembedsniproxy] Free windowAttributes in every case (authored by wbauer). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6389?vs=15883&id=15

D6389: [xembedsniproxy] Free windowAttributes in every case

2017-06-26 Thread Wolfgang Bauer
wbauer updated this revision to Diff 15883. wbauer edited the summary of this revision. wbauer added a comment. Use a QScopedPointer instead of manually calling free() REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6389?vs=15869&id=15883 REVISION

D6389: [xembedsniproxy] Free windowAttributes in every case

2017-06-26 Thread Wolfgang Bauer
wbauer created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The structure was only freed in case the XTest method was chosen. But it should always be freed of course (as long as it isn't NULL). TEST PL

D6252: [xembedsniproxy] Fix memleak and possible crash

2017-06-17 Thread Wolfgang Bauer
wbauer closed this revision. wbauer added a comment. Submitted to branch Plasma/5.10 with https://cgit.kde.org/plasma-workspace.git/commit/?id=a17de5957d4ba0f07c77fa99860c9046ff8aa1be (somehow this didn't get auto-closed) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabric

D6252: [xembedsniproxy] Fix memleak and possible crash

2017-06-17 Thread Wolfgang Bauer
wbauer created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Check the return value of xcb_get_window_attributes_reply() to prevent a crash if getting the window attributes would fail for some reason.

D6048: [xembedsniproxy] Fix check whether to use XTest

2017-05-31 Thread Wolfgang Bauer
This revision was automatically updated to reflect the committed changes. Closed by commit R120:7df184afa19f: [xembedsniproxy] Fix check whether to use XTest (authored by wbauer). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6048?vs=15014&id=15017

D6048: [xembedsniproxy] Fix check whether to use XTest

2017-05-31 Thread Wolfgang Bauer
wbauer added a comment. In https://phabricator.kde.org/D6048#113217, @davidedmundson wrote: > > Btw, I think the whole fix should probably be backported to 5.8 too... > > It introduces a new dependency :/ Really? AFAICS it only additionaly links xembedsniproxy against XTst.

D6048: [xembedsniproxy] Fix check whether to use XTest

2017-05-31 Thread Wolfgang Bauer
wbauer added a comment. Is it ok to commit it to the 5.10 branch as well? Btw, I think the whole fix should probably be backported to 5.8 too... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6048 To: wbauer, #plasma, davidedmundson Cc: plasma-devel, Z

D6048: [xembedsniproxy] Fix check whether to use XTest

2017-05-31 Thread Wolfgang Bauer
wbauer created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Because of C++'s operator precedence, '!' logically negated all_event_masks only instead of the whole expression. This resulted in the condit

[Powerdevil] [Bug 366299] System setting "Energy Saving" window is too large for a standard laptop screen

2016-12-16 Thread Wolfgang Bauer
https://bugs.kde.org/show_bug.cgi?id=366299 --- Comment #7 from Wolfgang Bauer --- (In reply to Pavel from comment #6) > (In reply to Wolfgang Bauer from comment #5) > > For now, just open the settings in systemsettings5 ("Configure Desktop" in > > openSUSE), and they w

[Powerdevil] [Bug 366299] System setting "Energy Saving" window is too large for a standard laptop screen

2016-12-14 Thread Wolfgang Bauer
https://bugs.kde.org/show_bug.cgi?id=366299 --- Comment #5 from Wolfgang Bauer --- (In reply to Pavel from comment #4) > but as far as I remember, there was a scrollbar on the right side > of the window, so I was able to scroll the frame with settings controls by > using this scrollbar

[Differential] [Changed Subscribers] D2894: Start KDE Cleanups

2016-11-02 Thread wbauer (Wolfgang Bauer)
wbauer added inline comments. INLINE COMMENTS > startkde.cmake:295 > > $qdbus org.kde.KSplash /KSplash org.kde.KSplash.setStage kinit & > $qdbus is still being used here, so this won't work anymore I suppose... REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabr

[Powerdevil] [Bug 366299] System setting "Energy Saving" window is too large for a standard laptop screen

2016-10-08 Thread Wolfgang Bauer via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366299 Wolfgang Bauer changed: What|Removed |Added CC||wba...@tmo.at --- Comment #3 from Wolfgang

[Powerdevil] [Bug 365281] ksystemsettings5 powerdevilprofilesconfig module doesn't fit to height in standalone

2016-10-03 Thread Wolfgang Bauer via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365281 Wolfgang Bauer changed: What|Removed |Added CC||wba...@tmo.at Status|UNCONFIRMED

[Powerdevil] [Bug 366299] System setting "Energy Saving" window is too large for a standard laptop screen

2016-10-03 Thread Wolfgang Bauer via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366299 Wolfgang Bauer changed: What|Removed |Added CC||housegregory...@gmail.com --- Comment #2 from

Re: Review Request 128815: Fix themes list with SDDM 0.14

2016-09-03 Thread Wolfgang Bauer
> On Sept. 2, 2016, 8:17 nachm., Fabian Vogt wrote: > > IMO you should use the same method as sddm, which is hardcoded at configure > > time: "@DATA_INSTALL_DIR@/themes". I agree. This change will still make it use ~/.local/share/sddm/themes/ if it should exist for some reason, and ignore /usr

[Differential] [Commented On] D2610: Make icon follow styleHints

2016-08-30 Thread wbauer (Wolfgang Bauer)
wbauer added a comment. In https://phabricator.kde.org/D2610#48966, @colomar wrote: > or clicking on a different widget on the desktop might execute an action immediately, which is inconsistent again. It's just that those two are more like (folderview) icons than other widgets.

[Differential] [Commented On] D2610: Make icon follow styleHints

2016-08-30 Thread wbauer (Wolfgang Bauer)
wbauer added a comment. In https://phabricator.kde.org/D2610#48934, @colomar wrote: > The only raison d'être for "double-click to open" is to be able to select on single click. If selecting is not possible (as is the case both in the panel and in a desktop containment), there is no reaso

Re: Review Request 128703: [kcm_mouse] Sync KDE4 config after writing the KF5 settings, not before

2016-08-18 Thread Wolfgang Bauer
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 4f4da83327e66f125c8dd1749df8efe1b5084945 by Wolfgang Bauer to branch Plasma/5.7. Bugs: 348254 and 367074 https://bugs.kde.org/show_bug.cgi?id=348254 https://bugs.kde.org/show_bug.cgi?id=367074

Re: Review Request 128703: [kcm_mouse] Sync KDE4 config after writing the KF5 settings, not before

2016-08-18 Thread Wolfgang Bauer
r KF5. Before, the old settings (before clicking Apply) were saved to KDE4, the Mouse settings in kcminputrc were not written at all. Thanks, Wolfgang Bauer

Re: Review Request 128703: [kcm_mouse] Sync KDE4 config after writing the KF5 settings, not before

2016-08-17 Thread Wolfgang Bauer
s are written correctly now, they are the same as for KF5. Before, the old settings (before clicking Apply) were saved to KDE4, the Mouse settings in kcminputrc were not written at all. Thanks, Wolfgang Bauer

Re: Review Request 128703: [kcm_mouse] Sync KDE4 kdeglobals after writing the KF5 settings

2016-08-17 Thread Wolfgang Bauer
128703/#review98441 --- On Aug. 17, 2016, 4:47 p.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://g

Re: Review Request 128703: [kcm_mouse] Sync KDE4 kdeglobals after writing the KF5 settings

2016-08-17 Thread Wolfgang Bauer
ly, visit: https://git.reviewboard.kde.org/r/128703/#review98435 ------- On Aug. 17, 2016, 4:47 p.m., Wolfgang Bauer wrote: > > --- > This is an automatically gene

Re: Review Request 128703: [kcm_mouse] Sync KDE4 kdeglobals after writing the KF5 settings

2016-08-17 Thread Wolfgang Bauer
e.cpp 3dbda19 Diff: https://git.reviewboard.kde.org/r/128703/diff/ Testing --- Change between single-click and double-click and apply. The KDE4 setting is written correctly now, it is the same as for KF5. Before it was inverted, i.e. the previous one. Thanks, Wolfgang Bauer

Re: Review Request 128703: [kcm_mouse] Sync KDE4 kdeglobals after writing the KF5 settings

2016-08-17 Thread Wolfgang Bauer
me as for KF5. Before it was inverted, i.e. the previous one. Thanks, Wolfgang Bauer

Review Request 128703: [kcm_input] Sync KDE4 kdeglobals after writing the KF5 settings

2016-08-17 Thread Wolfgang Bauer
https://git.reviewboard.kde.org/r/128703/diff/ Testing --- Change between single-click and double-click and apply. The KDE4 setting is written correctly now, it is the same as for KF5. Before it was inverted, i.e. the previous one. Thanks, Wolfgang Bauer

Re: Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

2016-05-30 Thread Wolfgang Bauer
marked as submitted. Review request for KDE Frameworks, Plasma and David Faure. Changes --- Submitted with commit c2aa2a46d51793d26dc6e93e60b5933cb1193e56 by Wolfgang Bauer to branch Plasma/5.6. Bugs: 356237 https://bugs.kde.org/show_bug.cgi?id=356237 Repository: kde-cli-tools

Re: Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

2016-05-30 Thread Wolfgang Bauer
e/mime/packages/ or ~/.local/share/mime/, if they exist. Enter the file types editor and modify a file type (e.g. add/change the icon), then press OK or Apply. Close it and open it again. The changes are still there now, before they were not applied and reverted to the system defaults. Thanks,

Re: Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

2016-05-30 Thread Wolfgang Bauer
mail. To reply, visit: https://git.reviewboard.kde.org/r/128055/#review96036 --- On Mai 30, 2016, 2:33 nachm., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-

Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

2016-05-30 Thread Wolfgang Bauer
K or Apply. Close it and open it again. The changes are still there now, before they were not applied and reverted to the system defaults. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127698: Always write the theme name to plasmarc, also if the default theme is chosen

2016-04-22 Thread Wolfgang Bauer
marked as submitted. Review request for Plasma. Changes --- Submitted with commit d884119f5a4a618eb30baaf5cd0ef058269b27f3 by Wolfgang Bauer to branch master. Repository: plasma-framework Description --- Currently, the "name" key is deleted from plasmarc when you

Re: Review Request 127623: [digital-clock] Fix display of seconds with certain locales

2016-04-22 Thread Wolfgang Bauer
marked as submitted. Review request for Plasma, Kai Uwe Broulik and Martin Klapetek. Changes --- Submitted with commit a7a22de14c360fa5c975e0bae30fc22e4cd7cc43 by Wolfgang Bauer to branch Plasma/5.6. Repository: plasma-workspace Description --- Currently, "Show Seconds&qu

Review Request 127698: Always write the theme name to plasmarc, also if the default theme is chosen

2016-04-20 Thread Wolfgang Bauer
patch Plasma will fall back to Air. Changing themes or the look&feel still works the same otherwise. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127623: [digital-clock] Fix display of seconds with certain locales

2016-04-14 Thread Wolfgang Bauer
1 Diff: https://git.reviewboard.kde.org/r/127623/diff/ Testing --- Switch locale to C, seconds are shown now or not, depending on the applet's configuration, they were not shown before even when enabled. It still behaves as expected with my standard locale (de_AT). Tha

Re: Review Request 127616: Digital clock applet re-write

2016-04-10 Thread Wolfgang Bauer
roduce, set the locale to "C" and enable "Show Seconds", the seconds won't be displayed. See https://git.reviewboard.kde.org/r/127623/ - Wolfgang Bauer On April 9, 2016, 5:23 nachm., Daniel Faust wrote: > > -

Review Request 127623: [digital-clock] Fix display of seconds with certain locales

2016-04-10 Thread Wolfgang Bauer
tch locale to C, seconds are shown now or not, depending on the applet's configuration, they were not shown before even when enabled. It still behaves as expected with my standard locale (de_AT). Thanks, Wolfgang Bauer ___ Plasma-devel mailing list

Re: Review Request 127499: [showdesktop] Fix sizing of the plasmoid in the panel

2016-03-26 Thread Wolfgang Bauer
marked as submitted. Review request for Plasma and Kai Uwe Broulik. Changes --- Submitted with commit e164ae7c02f5579e02d26842bee6a4a450e01871 by Wolfgang Bauer to branch Plasma/5.6. Repository: kdeplasma-addons Description --- Since 5.6, if you add a "Show Desktop" p

Review Request 127499: [showdesktop] Fix sizing of the plasmoid in the panel

2016-03-26 Thread Wolfgang Bauer
/uploaded/files/2016/03/26/98a734d1-ca67-4905-8137-9ed5c7dca11c__after.png Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127125: [plasmashell] Disable Qt's fallback session management

2016-02-25 Thread Wolfgang Bauer
Feb. 22, 2016, 12:55 nachm., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127125/ > ---

Re: Review Request 127125: [plasmashell] Disable Qt's fallback session management

2016-02-22 Thread Wolfgang Bauer
he logout. With the patch, the desktop stays until logout is really confirmed, and is still usable if the user clicks "Cancel". Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127125: [plasmashell] Disable Qt's fallback session management

2016-02-22 Thread Wolfgang Bauer
oes care about > > applications getting killed too early and this fixes it. > > This one is yours, I'll push the other ones. > > Wolfgang Bauer wrote: > Well, actually I want to thank *you* very much for taking care about the > general session management issues,

Re: Review Request 127125: [plasmashell] Disable Qt's fallback session management

2016-02-20 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127125/#review92583 --- On Feb. 20, 2016, 3:51 nachm., Wolfgang Bauer wrote: > > --

Review Request 127125: [plasmashell] Disable Qt's fallback session management

2016-02-20 Thread Wolfgang Bauer
f the user clicks "Cancel". Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125462: Completely fix broken translations in keyboard KCM advanced page

2015-09-30 Thread Wolfgang Bauer
marked as submitted. Review request for Plasma and David Edmundson. Changes --- Submitted with commit 6d192f58efc1f4fc34e4ee1d6d072ba11a6a29a1 by Wolfgang Bauer to branch Plasma/5.4. Bugs: 341527 https://bugs.kde.org/show_bug.cgi?id=341527 Repository: plasma-desktop Description

Re: Review Request 125462: Completely fix broken translations in keyboard KCM advanced page

2015-09-30 Thread Wolfgang Bauer
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/30/c3c67172-12fd-4cee-ad78-1a873edb62f2__before.png After https://git.reviewboard.kde.org/media/uploaded/files/2015/09/30/08a4ab30-b7ec-4db2-ae34-dce0bbc9e62e__after.png Thanks, Wolfgang Bauer __

Re: Review Request 125462: Completely fix broken translations in keyboard KCM advanced page

2015-09-30 Thread Wolfgang Bauer
lly generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125462/#review86153 ------- On Sept. 30, 2015, 1:07 nachm., Wolfgang Bauer wrote: > > --- > T

Re: Review Request 125462: Completely fix broken translations in keyboard KCM advanced page

2015-09-30 Thread Wolfgang Bauer
. - Wolfgang --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125462/#review86152 --- On Sept. 30, 2015, 1:07 nachm., Wolfga

Review Request 125462: Completely fix broken translations in keyboard KCM advanced page

2015-09-30 Thread Wolfgang Bauer
/media/uploaded/files/2015/09/30/08a4ab30-b7ec-4db2-ae34-dce0bbc9e62e__after.png Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125191: Allow to set minimum user id lower than 1000

2015-09-12 Thread Wolfgang Bauer
marked as submitted. Review request for Plasma and David Edmundson. Changes --- Submitted with commit 9afb3c627bb43969edf1a9bbe83b2107e002eb4f by Wolfgang Bauer to branch Plasma/5.4. Bugs: 347942 https://bugs.kde.org/show_bug.cgi?id=347942 Repository: sddm-kcm Description

Re: Review Request 125191: Allow to set minimum user id lower than 1000

2015-09-12 Thread Wolfgang Bauer
.conf). I just tried. - Wolfgang --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125191/#review85249 --- On Sept. 12, 2015, 1:35 nachm.,

Re: Review Request 125191: Allow to set minimum user id lower than 1000

2015-09-12 Thread Wolfgang Bauer
alue for the setting, see line 81. - Wolfgang --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125191/#review85249 --- On Sept. 12, 2015,

Review Request 125191: Allow to set minimum user id lower than 1000

2015-09-12 Thread Wolfgang Bauer
- src/advanceconfig.cpp 58e9f98 Diff: https://git.reviewboard.kde.org/r/125191/diff/ Testing --- Set the minimum user id to 500 e.g., it does now get saved correctly. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 125189: Fix loading of the configured cursor theme

2015-09-12 Thread Wolfgang Bauer
marked as submitted. Review request for Plasma and David Edmundson. Changes --- Submitted with commit c458a098c0271517ba59d65290d5b1b7c2577495 by Wolfgang Bauer to branch Plasma/5.4. Bugs: 344592 https://bugs.kde.org/show_bug.cgi?id=344592 Repository: sddm-kcm Description

Review Request 125189: Fix loading of the configured cursor theme

2015-09-12 Thread Wolfgang Bauer
-- Open the KCM, the currently configured Cursor theme is now shown correctly. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[kwrited] [Bug 351665] KDE shown hidden menu items available but not openable

2015-08-25 Thread Wolfgang Bauer
https://bugs.kde.org/show_bug.cgi?id=351665 --- Comment #4 from Wolfgang Bauer --- PS: (In reply to Nick Levinson from comment #2) > Clicking on the Software Updater icon or the Battery Monitor icon worked but > clicking on the Notifications icon did nothing. If that means there w

[kwrited] [Bug 351665] KDE shown hidden menu items available but not openable

2015-08-25 Thread Wolfgang Bauer
https://bugs.kde.org/show_bug.cgi?id=351665 Wolfgang Bauer changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution

[kwrited] [Bug 351665] KDE shown hidden menu items available but not openable

2015-08-23 Thread Wolfgang Bauer
https://bugs.kde.org/show_bug.cgi?id=351665 Wolfgang Bauer changed: What|Removed |Added CC||wba...@tmo.at --- Comment #1 from Wolfgang

Re: Review Request 124171: Fix applying user settings at login

2015-06-26 Thread Wolfgang Bauer
marked as submitted. Review request for Plasma and David Edmundson. Changes --- Submitted with commit 6663ebc14dd9b14f41498c617157e2f059165734 by Wolfgang Bauer to branch frameworks. Bugs: 218668 http://bugs.kde.org/show_bug.cgi?id=218668 Repository: kgamma Description

Re: Review Request 124171: Fix applying user settings at login

2015-06-25 Thread Wolfgang Bauer
--- Change the Gamma settings and logout/login. The settings are now applied again during login, whereas they weren't before. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-24 Thread Wolfgang Bauer
default). Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-24 Thread Wolfgang Bauer
at is configured for X (or its default). Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-24 Thread Wolfgang Bauer
rated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60866 ------- On June 23, 2014, 7:01 p.m., Wolfgang Bauer wrote: > > --- > This is a

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
> On June 23, 2014, 5:13 p.m., Martin Gräßlin wrote: > > kcmkgamma/init_kgamma.cpp, line 39 > > <https://git.reviewboard.kde.org/r/118898/diff/1/?file=283881#file283881line39> > > > > why delete config? I would just use a KSharedConfig::openConfig > >

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
anyway? But that's not really related to this bugfix, I'd say... - Wolfgang --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60809 ----

  1   2   >