> On June 24, 2014, 12:41 a.m., Christoph Feck wrote: > > Not sure why you added Marcel to the list of reviewers... > > > > Anyway, if the current patch is all that is needed to restore sanity as in > > KDE 3, the I am all for getting it fixed. > > Christoph Feck wrote: > (And if the same issue was the cause for the KRandR regression, then I > will eat my hat).
> Not sure why you added Marcel to the list of reviewers... Because he is listed as "KDE Project Manager" at https://projects.kde.org/projects/kde/kdegraphics/kgamma . > Anyway, if the current patch is all that is needed to restore sanity as in > KDE 3, the I am all for getting it fixed. It works fine here... > (And if the same issue was the cause for the KRandR regression, then I will > eat my hat). I don't think so. KRandR didn't use kcminit at all as far as I can see by having a quick glance at the source code. Instead it contains a script "krandrstartup" to apply the config, which is (still) sourced by startkde. - Wolfgang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60866 ----------------------------------------------------------- On June 23, 2014, 7:01 p.m., Wolfgang Bauer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118898/ > ----------------------------------------------------------- > > (Updated June 23, 2014, 7:01 p.m.) > > > Review request for kde-workspace, Plasma and Marcel Wiesweg. > > > Bugs: 218668 > http://bugs.kde.org/show_bug.cgi?id=218668 > > > Repository: kgamma > > > Description > ------- > > KGamma's saved user settings are not applied on startup/login. The user has > to enter the KCM to apply them. > This makes it rather useless, as not even saving the settings system-wide > really works any more. (this requires an xorg.conf which normally doesn't > exist nowadays) > > This patch uses kcminit to apply these settings again on login. Apparently > this has been forgotten when moving/porting kgamma to KDE4. > > PS: As there seems to be no kgamma group and this is desktop-related, I > decided to add the kde-workspace and plasma groups for review. I hope that's > ok... ;) > > > Diffs > ----- > > kcmkgamma/kgamma.cpp 890ba99 > kcmkgamma/kgamma.desktop 3d87513 > > Diff: https://git.reviewboard.kde.org/r/118898/diff/ > > > Testing > ------- > > Set a gamma value in the KGamma KCM, logout/login (or reboot), Gamma value > gets set correctly. > > If there's no kgammarc file (or it contains no actual gamma settings), the > Gamma value is not changed. It stays at what is configured for X (or its > default). > > > Thanks, > > Wolfgang Bauer > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
