> On Sept. 30, 2015, 1:15 nachm., David Edmundson wrote: > > kcms/keyboard/xkb_rules.cpp, line 74 > > <https://git.reviewboard.kde.org/r/125462/diff/1/?file=408926#file408926line74> > > > > >Note that QString::toHtmlEscaped() cannot be used here because it > > would also convert '"', which is contained verbatim in the translation > > files. > > > > > > As a general guide if you need to explain something in a commit log, > > you should put that comment in the code too
Yeah, I didn't explicitly mention toHTMLEscaped() in the comment, but thought later I should in the review request. Will add that to the comment in the code when I submit. - Wolfgang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125462/#review86153 ----------------------------------------------------------- On Sept. 30, 2015, 1:07 nachm., Wolfgang Bauer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125462/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2015, 1:07 nachm.) > > > Review request for Plasma and David Edmundson. > > > Bugs: 341527 > https://bugs.kde.org/show_bug.cgi?id=341527 > > > Repository: plasma-desktop > > > Description > ------- > > The xkeyboard-config translation files contain the characters '<' and '>' in > HTML-escaped form. Therefore we need to convert them before/after looking up > the translation. > > Note that QString::toHtmlEscaped() cannot be used here because it would also > convert '"', which is contained verbatim in the translation files. > > > Diffs > ----- > > kcms/keyboard/xkb_rules.cpp 27ff104 > > Diff: https://git.reviewboard.kde.org/r/125462/diff/ > > > Testing > ------- > > Ran "kcmshell5 keyboard" on a german system, all options are correctly > translated now, see attached screenshots. > > > File Attachments > ---------------- > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/30/c3c67172-12fd-4cee-ad78-1a873edb62f2__before.png > After > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/30/08a4ab30-b7ec-4db2-ae34-dce0bbc9e62e__after.png > > > Thanks, > > Wolfgang Bauer > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
