> On Sept. 2, 2016, 8:17 nachm., Fabian Vogt wrote: > > IMO you should use the same method as sddm, which is hardcoded at configure > > time: "@DATA_INSTALL_DIR@/themes".
I agree. This change will still make it use ~/.local/share/sddm/themes/ if it should exist for some reason, and ignore /usr/share/sddm/themes/ in that case. Or use QStandardPaths::locateAll(), but sddm only looks in "@DATA_INSTALL_DIR@/themes" anyway and will not load themes from ~/.local/share or other $XDG_DATA_DIRS locations. - Wolfgang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128815/#review98833 ----------------------------------------------------------- On Sept. 2, 2016, 7:51 nachm., Antonio Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128815/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2016, 7:51 nachm.) > > > Review request for Plasma and David Edmundson. > > > Repository: sddm-kcm > > > Description > ------- > > SDDM 0.14 apparently creates a ~/.local/share/sddm dir to store some logs, > which makes sddm-kcm look for themes there instead of /usr/share/sddm > Additionally, fix the config key for themes dir in sddm.conf > > > Diffs > ----- > > src/themesmodel.cpp 5af9c54 > > Diff: https://git.reviewboard.kde.org/r/128815/diff/ > > > Testing > ------- > > Themes list works again with SDDM 0.14 > > > Thanks, > > Antonio Rojas > >
