D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

vhanda added a comment. Sorry. I'm removing myself as a reviewer. I barely remember this code base. It has been way too many years. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27070 To: alex, #plasma Cc: vhanda, plasma-devel, Orage, LeGast00n, The-Feren-OS

Re: Baloo maintainer required

On Mon, Sep 19, 2016 at 11:43 AM, Bhushan Shah wrote: > Hey Vishesh, > > On Mon, Sep 19, 2016 at 3:06 PM, Vishesh Handa wrote: >> I've been steadily loosing motivation to work on Baloo. >> >> I've removed myself from all the bugs, as it doesn't seem like

Baloo maintainer required

If someone else wants to maintain it, I can help with the transition. -- Vishesh Handa

Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/#review99115 --- Ship it! This is awesome. Ship it. - Vishesh Handa On

[Differential] [Accepted] D2395: [Milou] Optimize and cleanup sources model

vhanda accepted this revision. vhanda added a comment. This revision is now accepted and ready to land. Looks good. REPOSITORY rMILOU Milou REVISION DETAIL https://phabricator.kde.org/D2395 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #pl

Re: KRunner Maintainer Required

Hahaha. This clearly shows how bad the situation is. Thanks Kai. -- Vishesh Handa On Sun, Apr 17, 2016 at 11:43 PM, Kai Uwe Broulik wrote: > Check your emails, I already took maintainership couple of days ago :D > > > Ursprüngliche Nachricht > Von:m...@vhanda.in > Gesen

KRunner Maintainer Required

nd actually get the ball moving. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1185: drkonqi mappings: Move baloo_file* to "frameworks-baloo|Baloo File Daemon"

vhanda added a comment. A big -1 from me. This is going to affect users with the most recent version of Plasma, which means previous versions will still keep filing bugs against Baloo. If anything, "frameworks-baloo" should be deleted. It's too late to change the product name. If someon

[Differential] [Accepted] D908: [Baloo Runner] Add mime data to matches

vhanda accepted this revision. vhanda added a comment. This revision is now accepted and ready to land. I'm guessing this is for drag and drop. Seems fairly straightforward. INLINE COMMENTS runners/baloo/baloosearchrunner.cpp:180 I don't think this is required. From the QMimeData d

Re: Review Request 126878: [KRunner] Show single runner name

> On Jan. 27, 2016, 9 a.m., Vishesh Handa wrote: > > * A single runner can have multiple categories in its response. > > * I see nothing from a technical point of view in the patch. I find it > > slightly ugly, but if the usability guys (and Plasma) are fine with it, &

Re: Review Request 126877: [Milou] Expose single runner name and icon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126877/#review91647 --- Ship it! Ship It! - Vishesh Handa On Jan. 24, 2016, 9

Re: Review Request 126878: [KRunner] Show single runner name

response. * I see nothing from a technical point of view in the patch. I find it slightly ugly, but if the usability guys (and Plasma) are fine with it, ship it! - Vishesh Handa On Jan. 24, 2016, 9:49 p.m., Kai Uwe Broulik wrote: > > ---

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125129/#review89509 --- Ship it! Ship It! - Vishesh Handa On Dec. 6, 2015, 2:18

Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

> On Sept. 24, 2015, 11:50 p.m., Vishesh Handa wrote: > > runners/baloo/baloosearchrunner.cpp, line 165 > > <https://git.reviewboard.kde.org/r/125369/diff/1/?file=405159#file405159line165> > > > > Have a look at basicindexingjob.txt. We define that all Prese

Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

> On Sept. 24, 2015, 11:50 p.m., Vishesh Handa wrote: > > runners/baloo/baloosearchrunner.cpp, line 165 > > <https://git.reviewboard.kde.org/r/125369/diff/1/?file=405159#file405159line165> > > > > Have a look at basicindexingjob.txt. We define that all Prese

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

> On Sept. 15, 2015, 9:33 p.m., Vishesh Handa wrote: > > Maybe we could just add this to our `IndexerConfig` class so that users of > > our API don't need to know about dbus interfaces? Specially since I'm not > > too keen on maintaining API comatibility in the d

Re: Review Request 126100: [KRunner] Forward KRunner switchUser to KSMServer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126100/#review88555 --- Ship it! - Vishesh Handa On Nov. 17, 2015, 7:09 p.m., Kai

Re: Remove plasma-desktop/useraccount code?

On Oct 9, 2015 15:40, "Sebastian Kügler" wrote: > > On Friday, October 09, 2015 13:46:49 Vishesh Handa wrote: > > So if you want to delete the code, go ahead, just leave the avatars. I > > don't think you even need to go through review, the original person >

Re: Remove plasma-desktop/useraccount code?

On Oct 9, 2015 14:02, "Jonathan Riddell" wrote: > > On Fri, Oct 09, 2015 at 01:46:49PM +0200, Vishesh Handa wrote: > > So if you want to delete the code, go ahead, just leave the avatars. I > > don't think you even need to go through review, the original pers

Re: Remove plasma-desktop/useraccount code?

On Sat, Sep 26, 2015 at 3:30 PM, Albert Astals Cid wrote: > Please CC me i'm not subscribed. > > Should we remove plasma-desktop/useraccount since we're not compiling it > anymore? Sadly, we cannot just remove it. It has avatars which are still shipped. A commit without review was made to disabl

Re: KCM's and Plasma-desktop

On Fri, Oct 9, 2015 at 1:32 PM, wrote: > On Friday, October 09, 2015 01:30:25 PM Vishesh Handa wrote: >> Baloo is only for linux. Windows has its own search solution far >> superior to ours. > > I would not call it superior to ours, at least compared to Windows 8... That &g

Re: KCM's and Plasma-desktop

On Mon, Oct 5, 2015 at 5:20 PM, Hannah von Reth wrote: > Baloo could be useful. Baloo is only for linux. Windows has its own search solution far superior to ours. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

> On Sept. 15, 2015, 9:33 p.m., Vishesh Handa wrote: > > Maybe we could just add this to our `IndexerConfig` class so that users of > > our API don't need to know about dbus interfaces? Specially since I'm not > > too keen on maintaining API comatibility in the d

Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

eld "Source Code" or something. I'm not sure, but just combining the two doesn't seem correct. Maybe others can chime in? - Vishesh Handa On Sept. 24, 2015, 7:18 a.m., Igor Poboiko wrote: > > --- > This

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

used to exist because there was no explicit "Disable Baloo button". Now that there is the button, do we want to magically disable Baloo if nothing is going to be indexed? I think so, though I'm not sure. Anyway, ship it. Nice work, and sorry for the delay. - Vishesh Handa On Sept.

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

> On Sept. 15, 2015, 9:33 p.m., Vishesh Handa wrote: > > Maybe we could just add this to our `IndexerConfig` class so that users of > > our API don't need to know about dbus interfaces? Specially since I'm not > > too keen on maintaining API comatibility in the d

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

tps://git.reviewboard.kde.org/r/125117/#comment59063> I'm really not too sure about this. So the display name is taken and that is compared with the mountPoint? The display name isn't always equal to the mount path or is it? http://doc.qt.io/qt-5/qstorageinfo.html#displayName - Vi

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

that users of our API don't need to know about dbus interfaces? Specially since I'm not too keen on maintaining API comatibility in the dbus interface. - Vishesh Handa On Sept. 10, 2015, 5:56 a.m., Pinak Ahuja wrote: > >

Re: Review Request 125107: Renamed functions and variables for better Qt compliance and better description

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125107/#review85028 --- Ship it! - Vishesh Handa On Sept. 8, 2015, 7:02 p.m

Re: Review Request 125062: Renamed variable for better description

tps://git.reviewboard.kde.org/r/125062/#comment58736> Does this actually compile? Because 'folderDisplayName' does not exist for me. - Vishesh Handa On Sept. 5, 2015, 8:05 p.m., Ovidiu-Florin BOGDAN wrote: > > --- >

Re: Review Request 125061: Moved indexing checkbox to the top of the KCM

my specific needs better". - Vishesh Handa On Sept. 5, 2015, 8:03 p.m., Ovidiu-Florin BOGDAN wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 125060: Added .gitignore

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125060/#review84895 --- Ship it! - Vishesh Handa On Sept. 5, 2015, 8:01 p.m

Re: Review Request 125058: Cleanup and Add directories to index list

----- > > (Updated Sept. 5, 2015, 8:11 p.m.) > > > Review request for Baloo, Plasma, KDE Usability, Pinak Ahuja, and Vishesh > Handa. > > > Repository: plasma-desktop > > > Description > --- > > Adde

Re: Review Request 125058: Cleanup and Add directories to index list

excluded, but > there are currently child directories of that directory that are included. In > this case, I'd show a warning, but let the user do it. > > > P.S. Please take a look over the Review Requests that this one depends > on. I can't submit the othe

Re: Review Request 125058: Cleanup and Add directories to index list

> On Sept. 5, 2015, 12:12 p.m., Vishesh Handa wrote: > > kcms/baloo/configwidget.ui, line 43 > > <https://git.reviewboard.kde.org/r/125058/diff/1/?file=400370#file400370line43> > > > > Moving the checkBox from the top to bottom? Why? Also, if we want this

Re: Review Request 125058: Cleanup and Add directories to index list

dget.cpp (line 282) <https://git.reviewboard.kde.org/r/125058/#comment58725> `QStringLiteral` - Vishesh Handa On Sept. 5, 2015, 11:33 a.m., Ovidiu-Florin BOGDAN wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 125058: Cleanup and Add directories to index list

> On Sept. 5, 2015, 12:12 p.m., Vishesh Handa wrote: > > Can you please attach some images of how the KCM now looks? > > Ovidiu-Florin BOGDAN wrote: > Should I make a new review request with each patch? Or a single one with > 3 diffs? A new review request per patch

Re: Review Request 125058: Cleanup and Add directories to index list

> On Sept. 5, 2015, 12:12 p.m., Vishesh Handa wrote: > > kcms/baloo/configwidget.ui, line 43 > > <https://git.reviewboard.kde.org/r/125058/diff/1/?file=400370#file400370line43> > > > > Moving the checkBox from the top to bottom? Why? Also, if we want this

Re: Review Request 125058: Cleanup and Add directories to index list

/git.reviewboard.kde.org/r/125058/#comment58708> Coding style. The { should not be on the next line. Please fix all instances of this. - Vishesh Handa On Sept. 5, 2015, 11:33 a.m., Ovidiu-Florin BOGDAN wrote: > > --- >

Re: Notes from Plasma BoF

On Mon, Jul 27, 2015 at 3:01 PM, Sebastian Kügler wrote: > - new Xapian-replacement backend for Baloo (check with Vishesh) Yup. Also Baloo is moving to Frameworks, and will not be part of Plasma 5.4 Vishesh Handa ___ Plasma-devel mailing l

Re: baloo monitor visibility

ke it a very power user feature, just like the 'balooctl', 'baloosearch' and 'balooshow' tools. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124037: Allow to cancel critical battery timer

> On June 9, 2015, 5:28 p.m., Vishesh Handa wrote: > > We could also possibly show a big countdown via an OSD and add a kind of a > > snooze button which would gives you another 30 seconds. > > Kai Uwe Broulik wrote: > Omg please no I'm not sure if you&#x

Re: Review Request 124037: Allow to cancel critical battery timer

add a kind of a snooze button which would gives you another 30 seconds. - Vishesh Handa On June 8, 2015, 5:30 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 123888: [krunner] Bring back history

or position to be updated for runners which change the query string. You can test this out with the calculator runner. Does this break something? - Vishesh Handa On May 23, 2015, 11:40 p.m., Kai Uwe Broulik wrote: > > --- >

Re: Review Request 123889: [krunner] Add button to clear history

. kcms/runners/kcm.cpp (line 64) <https://git.reviewboard.kde.org/r/123889/#comment55385> Please use `KConfigGroup::deleteEntry` - Vishesh Handa On May 23, 2015, 10:01 p.m., Kai Uwe Broulik wrote: > > --- > This is a

Re: Review Request 123735: version of QmlObject with a static engine

ed pointer are the only references to it. - Vishesh Handa On May 21, 2015, 10:52 a.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https

Re: Review Request 123735: version of QmlObject with a static engine

tps://git.reviewboard.kde.org/r/123735/#comment55306> It would be awesome if we could have some tests for this class. Maybe we can just try and copy the QQuickView tests? http://code.qt.io/cgit/qt/qtdeclarative.git/tree/tests/auto/quick/qquickview/tst_qquickview.cpp - Vishesh Hand

Re: Review Request 123735: version of QmlObject with a static engine

> On May 19, 2015, 3:04 p.m., Vishesh Handa wrote: > > src/kdeclarative/qmlobjectsharedengine.cpp, line 60 > > <https://git.reviewboard.kde.org/r/123735/diff/8/?file=370102#file370102line60> > > > > I'm probably missing some parts of the picture. Could

Re: Review Request 123735: version of QmlObject with a static engine

some parts of the picture. Could you please explain why this needs to be static? Also, you could just combine the QSharedPointer and the normal pointer. - Vishesh Handa On May 18, 2015, 8 p.m., Marco Martin wrote: > > --- >

Re: Review Request 123378: Krunner results shouldn't follow showAppsByName

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123378/#review79115 --- Seems reasonable. - Vishesh Handa On April 15, 2015, 10:13

Re: Minutes Monday Plasma Hangout

On Mon, Apr 13, 2015 at 12:38 PM, Sebastian Kügler wrote: > * Possible mismatch between Dolphin and Plasma, since they use different > baloo > databases > Could you please elaborate? -- Vishesh Handa ___ Plasma-devel mailing list

Re: 5.3 errata

On Thu, Apr 9, 2015 at 11:25 PM, Eike Hein wrote: > On 04/09/2015 11:01 PM, Vishesh Handa wrote: > >> KDE 4.9 - No errata >> KDE 4.10 - No errata >> KDE 4.11 - No errata >> > > https://community.kde.org/Plasma/5.0_Errata > https://community.kde.org/Plasma

Re: 5.3 errata

acing after the release was packaged' [1]. That doesn't seem like an errata. Just for the record, I'm not against highlighting missing features on the errata. I am, however, very against linking to bugs from 2010, which aren't solvable. -- Vishesh Handa [1] https://www.kde

Re: 5.3 errata

On Thu, Apr 9, 2015 at 10:32 PM, Jonathan Riddell wrote: > On Thu, Apr 09, 2015 at 10:30:34PM +0200, Vishesh Handa wrote: > >On Thu, Apr 9, 2015 at 10:01 PM, Jonathan Riddell > wrote: > > > > On Thu, Apr 09, 2015 at 07:14:18PM +0200, Vishesh Handa wrote: >

Re: 5.3 errata

On Thu, Apr 9, 2015 at 10:01 PM, Jonathan Riddell wrote: > On Thu, Apr 09, 2015 at 07:14:18PM +0200, Vishesh Handa wrote: > >Hi Johnathan > >Could you please tell me what is accomplished by creating this errata > >page? > > It means people can see what

Re: 5.3 errata

Hi Johnathan Could you please tell me what is accomplished by creating this errata page? -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Moving User Manager back to playground

s please let me know. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: PIM Sprint this Weekend

bring it up again. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: PIM Sprint this Weekend

n Akonad-Next, search will be properly integrated, and Baloo will play no role. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: PIM Sprint this Weekend

dex from Qt5. We do not need any Akonadi specific apis. I just haven't bothered writing the runner and doing it. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: PIM Sprint this Weekend

On Tue, Apr 7, 2015 at 10:51 AM, Martin Gräßlin wrote: > (boud's > blog post is a nice reminder that libraries should think about their users) > His blog is one big rant. I love it. He's completely right. -- Vishesh Handa ___ P

PIM Sprint this Weekend

Hey guys I'm travelling to Toulouse for the PIM Sprint this weekend. If there is anything specific anyone would like to me to discuss w.r.t Plasma, please let me know. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 122679: Show Desktop feature: refurbished

that'll likely be > required to find the desktop WId, QDesktopWidget is the root wid) Yes. It links against it. - Vishesh --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review77

Re: Release Dates for August

only user. I'm leaning towards 2, but I haven't done much. I'll post it on a separate email. We have some time. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Release Dates for August

group.calendar.google.com&ctz=Europe/Madrid > > Comments? > > Jonathan > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > -- Vishesh Handa

Re: 5.4 release schedule

is shipped with both frameworks and Plasma at the same time. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: 5.4 release schedule

ore, Dolphin (Qt4) searching will no longer work. I'm not willing to wait till Frameworks 5.9 + .6 = 5.15 Maybe we want to do something about this. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinf

Re: Review Request 123040: Make selection in krunner wrapping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123040/#review77833 --- Ship it! Go ahead then :) - Vishesh Handa On March 18

Re: Review Request 123040: Make selection in krunner wrapping

> On March 18, 2015, 10:36 p.m., Aleix Pol Gonzalez wrote: > > But do we really want this? > > Vishesh Handa wrote: > Doesn't seem like a bad idea. Specially since someone has asked for it. > Any particular reason you're against this? > > Pinak Ahuja w

Re: Review Request 123040: Make selection in krunner wrapping

> This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123040/ > --- > > (Updated March 18, 2015, 7:06 p.m.) > > > Review request for Plasma and Vishesh Handa. > > &

Re: Plasma Bugs

, when history shows us (Kde4) that that is not the case. > I'm open to ideas of better solutions, but at the sprint you didn't > provide any. You're not providing any here either. > I don't remember there being a discussion. Anyway, I have some ideas.

Re: Plasma Bugs

ink I'd mentioned this at the sprint as well, this is not a solution. It just throws the bugs under another place where none looks. I do not see the point of subscribing to a mailing list with such high traffic. If one wants to see what bugs haven't been triaged, there are bugzilla que

Re: Review Request 122450: Do not set global shortcuts for the Media keys

g/r/122450/#comment52826> Do we need to explicitly call `setGlobalShortcut( KShortcut() )` or can one just omit it alltogether? - Vishesh Handa On Feb. 6, 2015, 8:06 a.m., Martin Gräßlin wrote: > > --- > This is an automatica

Re: Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

aps we should be checking for it. dataengines/geolocation/location_ip.cpp <https://git.reviewboard.kde.org/r/122628/#comment52556> This is slightly strange. Normally it's given a double value, but otherwise we give it a string. Why not just not add it? - Vishesh Handa O

Re: Review Request 122562: Add method for converting from QVariant to base64

tps://git.reviewboard.kde.org/r/122562/#comment52519> Coding style src/qmlcontrols/kquickcontrolsaddons/clipboard.cpp <https://git.reviewboard.kde.org/r/122562/#comment52520> huh? The `case QVariant::String` does not matter. - Vishesh Handa On Feb. 13, 2015, 6:16 p.m

Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets

lasma-applet.desktop ff48afa Diff: https://git.reviewboard.kde.org/r/122502/diff/ Testing --- Tried by using this option to filter them in the windowed widgets runner. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets

sktop ff48afa Diff: https://git.reviewboard.kde.org/r/122502/diff/ Testing --- Tried by using this option to filter them in the windowed widgets runner. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kd

Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets

ed by using this option to filter them in the windowed widgets runner. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122371: Disable session management for kwrited

> On Feb. 8, 2015, 1:49 p.m., David Edmundson wrote: > > kwrited.cpp, line 74 > > > > > > why this? It's fine. Since kwrited doesn't have any UI, we can safely get away with this. It will reduce loading the curr

Re: Review Request 122312: Use sysconf() instead of relying on UT_NAMESIZE

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122312/#review75402 --- Ship it! Seems sensible. - Vishesh Handa On Jan. 29, 2015

Re: 5.2 features

mprovements by getting rid of the sqlite backend, but the side-effects weren't worth it :( -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122167: Unlink the temporary file for ShmPool from file system

should think about improving QTemporaryFile to do the same internally. - Vishesh Handa On Jan. 20, 2015, 9:35 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

[krunner] [Bug 343078] Must type the whole action name to get a search result in KRunner

https://bugs.kde.org/show_bug.cgi?id=343078 Vishesh Handa changed: What|Removed |Added Assignee|plasma-devel@kde.org|m...@vhanda.in Component|general

Re: Review Request 122040: Improve KRunner behavior on adding/removing screens

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122040/#review73946 --- Ship it! Good job! Gold star! - Vishesh Handa On Jan. 13

Re: Review Request 121201: KRunner: Do not detect anything with a '.' as a NetworkLocation

Diff: https://git.reviewboard.kde.org/r/121201/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.2 bits for kdereview

hold one-bullet/vs-three/vs-none of password dialogs. I'm fairly certain that is broken, but I need to test it out. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121476: Port showdesktop applet to Plasma Next

t too sure about the X11 parts, but given that no-one who knows about this X11 stuff has commented so far, please ship it. - Vishesh Handa On Dec. 13, 2014, 3:55 p.m., Ashish Madeti wrote: > > --- > This is an automatically g

Re: Review Request 121476: Port showdesktop applet to Plasma Next

> On Dec. 17, 2014, 12:16 p.m., Bhushan Shah wrote: > > applets/showdesktop/CMakeLists.txt, line 18 > > > > > > is this required? maybe port away from KDELibs4Support Lets just ship this for now, and let the port

Re: Moving kglobalacceld and framworks < 5.6

On Wed, Dec 17, 2014 at 11:55 AM, Martin Klapetek wrote: > > This will also mean that plasma 5.2 will not be buildable with frameworks > < 5.6, > is this ok? > Yes. We are already in this situation with Baloo and KFileMetaData. Both of them are going to become frameworks.

Re: Review Request 121476: Port showdesktop applet to Plasma Next

in/showdesktop.h <https://git.reviewboard.kde.org/r/121476/#comment50142> This timer isn't actually doing anything. - Vishesh Handa On Dec. 13, 2014, 2:14 p.m., Ashish Madeti wrote: > > --- > This is an automatically

Re: Review Request 121452: Call matchSessionComplete of RunnerManager in milou

that RunnerManager's reset doesn't just call matchSessionComplete. Maybe we should change it there. - Vishesh Handa On Dec. 11, 2014, 8:24 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail.

Re: Plasma 5.2 parts

On Thu, Dec 11, 2014 at 3:07 PM, Jonathan Riddell wrote: > > Baloo is becoming a framework, is that all to move? Presumably Milou > still one of ours? > * Baloo and KFileMetaData should become a framework. * Milou is still part of the workspace -- V

Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component

as this been tested? This assert would be true when m_level is Month or Day. - Vishesh Handa On Nov. 26, 2014, 6:11 p.m., Antonis Tsiapaliokas wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component

the Baloo documentation and submit a patch later. - Vishesh Handa On Nov. 26, 2014, 6:11 p.m., Antonis Tsiapaliokas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 121201: KRunner: Do not detect anything with a '.' as a NetworkLocation

cannot use Qt 5.4 right now. - Vishesh Handa On Nov. 21, 2014, 6:10 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component

> Just my opinion - An assert would be better since m_level is an enum and should NEVER be any other value apart from those 3. - Vishesh Handa On Nov. 25, 2014, 3:11 p.m., Antonis Tsiapaliokas wrote: > > --- > Thi

Review Request 121201: KRunner: Do not detect anything with a '.' as a NetworkLocation

/show_bug.cgi?id=340140 Repository: krunner Description --- One can also uses a decimal point in a calculator. Diffs - autotests/runnercontexttest.cpp ba5f6a1 src/runnercontext.cpp 2d6177d Diff: https://git.reviewboard.kde.org/r/121201/diff/ Testing --- Thanks, Vishesh Handa

Re: Plasma Media Center and external USB drives

well) > 2. Mount the USB device and let the user browse through files and play > them manually. > 3. Create your own local index of files in the USB stick. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component

inefficient. Could you please use Query::setDateFilter please. You should do the same for the month and days as well. - Vishesh Handa On Oct. 24, 2014, 12:21 p.m., Antonis Tsiapaliokas wrote: > > --- > This is an

Re: The usage statistics [kactivities, baloo, ktp, plasma]

icker currently uses Muon, which is part of the workspace. We can quite easily just ask it for newer applications and avoid having to diff ksyscoca scans and react to any signals or anything. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-de

  1   2   3   4   >