----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80630 -----------------------------------------------------------
src/kdeclarative/qmlobjectsharedengine.cpp (line 41) <https://git.reviewboard.kde.org/r/123735/#comment55280> On first run `s_engine` is 0, so this will not actually clean up the `QQmlEngine` src/kdeclarative/qmlobjectsharedengine.cpp (line 60) <https://git.reviewboard.kde.org/r/123735/#comment55281> I'm probably missing some parts of the picture. Could you please explain why this needs to be static? Also, you could just combine the QSharedPointer and the normal pointer. - Vishesh Handa On May 18, 2015, 8 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123735/ > ----------------------------------------------------------- > > (Updated May 18, 2015, 8 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > to make easier doing applications like plasma that use a lot of qml to have a > single engine make a subclass of QmlObject called QmlObjectSharedEngine that > has a single, static QQmlEngine > > Adds a class called QuickViewSharedEngine that has the same behavior as > QmlObjectSharedEngine(using it): static QQmlEngine, separed rootContexts() > for each instance. > This is used by desktopviews and panelviews to share their engine. > > Unfortunately it may not be possible to get the applet configuration dialogs > to use this, since they still need a separed engine in order to have a > different controls style (qstyle based) than the stuff in the desktop/panel > > > Diffs > ----- > > src/kdeclarative/CMakeLists.txt d73bff0 > src/kdeclarative/kdeclarative.cpp b3906e2 > src/kdeclarative/qmlobject.h f26b67d > src/kdeclarative/qmlobject.cpp c483665 > src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION > src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION > src/quickaddons/CMakeLists.txt 777d07c > src/quickaddons/quickviewsharedengine.h PRE-CREATION > src/quickaddons/quickviewsharedengine.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/123735/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
