----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123888/#review80790 -----------------------------------------------------------
Good work! Let me try it out myself and see how it feels. krunner/view.cpp (line 330) <https://git.reviewboard.kde.org/r/123888/#comment55386> It would be more efficient to use 'QList::removeOne` lookandfeel/contents/runcommand/RunCommand.qml (line 103) <https://git.reviewboard.kde.org/r/123888/#comment55387> We need the cursor position to be updated for runners which change the query string. You can test this out with the calculator runner. Does this break something? - Vishesh Handa On May 23, 2015, 11:40 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123888/ > ----------------------------------------------------------- > > (Updated May 23, 2015, 11:40 p.m.) > > > Review request for Plasma, KDE Usability and Vishesh Handa. > > > Bugs: 335731 > https://bugs.kde.org/show_bug.cgi?id=335731 > > > Repository: plasma-workspace > > > Description > ------- > > This turns KRunner's TextField into an editable ComboBox to provide a history. > > When a result is invoked, the query string is prepended to the history, query > strings are only added once. ComboBox provides letter-by-letter auto > completion. > > > Diffs > ----- > > krunner/view.h 1ad5075 > krunner/view.cpp 8640e1d > lookandfeel/contents/runcommand/RunCommand.qml 4c6eb30 > > Diff: https://git.reviewboard.kde.org/r/123888/diff/ > > > Testing > ------- > > Somehow I have a feeling it doesn't always save the history or nukes it at > times. It also has some shortcomings due to ComboBox: > > 1.) You cannot use the arrow keys to cycle between entries (when the popup's > not opened) because arrow keys navigate through results > 2.) forceActiveFocus() on the ComboBox will not activate the embedded > TextField - when you had opened the popup there's a slight chance the input > field won't get focussed I'll prepare a Qt patch for this. > 3.) Before Qt 5.4.2 (not sure if my patch ended up in 5.4.1) pressing space > in the edit combobox will open the popup, not insert a space (nasty show > stopper) > 4.) Plasma's edtiable ComboBox looks a bit strange imho > 5.) Plasma's editable ComboBox doesn't support clearButtonShown > 6.) Plasma's ComboBox has strange bullets and margins in it, that's probably > a bug in Plasma Style (need to look what Desktop style does differently from > us) > 7.) ComboBox doesn't have a cursorPosition, I'll prepare a Qt patch for this. > > > File Attachments > ---------------- > > History popup > > https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/7ad7e5eb-4874-4f9f-9796-738fa2ac9ed5__krunnerhistory.png > Auto completion > > https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/18714844-ef28-4cdd-af00-e6685caece9b__krunnerautocompletion.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
