----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121452/#review71860 -----------------------------------------------------------
Ship it! Good Catch. Though it's slightly annoying that RunnerManager's reset doesn't just call matchSessionComplete. Maybe we should change it there. - Vishesh Handa On Dec. 11, 2014, 8:24 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121452/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 8:24 p.m.) > > > Review request for Plasma and Vishesh Handa. > > > Bugs: 339972 > http://bugs.kde.org/show_bug.cgi?id=339972 > > > Repository: milou > > > Description > ------- > > RunnerManager requires matchSessionComplete to be called when it needs to be > cleaned up. Thus prepare and tear signal for runner plugin can be triggered > correctly. > > > Diffs > ----- > > lib/sourcesmodel.cpp cae6f06 > > Diff: https://git.reviewboard.kde.org/r/121452/diff/ > > > Testing > ------- > > window runner can work properly. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
