https://bugs.kde.org/show_bug.cgi?id=362988
--- Comment #5 from Emmanuel Pescosta ---
(In reply to Toralf Förster from comment #4)
> whilst https://git.reviewboard.kde.org/r/129134/diff/1#index_header solves a
> big fraction of this issue there's still 1 thing left:
Thanks for te
https://bugs.kde.org/show_bug.cgi?id=362988
Emmanuel Pescosta changed:
What|Removed |Added
Component|general |default
Version|15.12.3
https://bugs.kde.org/show_bug.cgi?id=368008
Emmanuel Pescosta changed:
What|Removed |Added
Component|webdav |default
Assignee|kdelibs-b
https://bugs.kde.org/show_bug.cgi?id=366795
Emmanuel Pescosta changed:
What|Removed |Added
CC||germano.massu...@gmail.com
--- Comment #20
> On May 10, 2016, 5:17 p.m., Emmanuel Pescosta wrote:
> > src/kpageview_p.cpp, line 402
> > <https://git.reviewboard.kde.org/r/127888/diff/1/?file=464590#file464590line402>
> >
> > option.state & (QStyle::State_Selected | QStyle::State_Active) maybe?
&
:State_Active) maybe?
- Emmanuel Pescosta
On May 10, 2016, 1:57 p.m., Marco Martin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
tps://git.reviewboard.kde.org/r/127888/#comment64660>
option.state & (QStyle::State_Selected | QStyle::State_Active) maybe?
- Emmanuel Pescosta
On May 10, 2016, 5:12 p.m., Marco Martin wrote:
>
> ---
> This is an automatically generat
e remaining code path as
the "QImageReader from path" to avoid breakages.
- Emmanuel Pescosta
On April 28, 2016, 1:53 p.m., Marco Martin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
https://bugs.kde.org/show_bug.cgi?id=351309
Emmanuel Pescosta changed:
What|Removed |Added
CC||bugs.kde.org.id324@vbgunz.c
place exactly the way you need it
and the storing/hashing of events can easily be changed in future if needed
(without changing the plugins).
- Emmanuel Pescosta
On Oct. 27, 2015, 10:10 p.m., Martin Klapetek wrote:
>
> ---
https://bugs.kde.org/show_bug.cgi?id=351309
Emmanuel Pescosta changed:
What|Removed |Added
CC||demsk...@gmail.com
--- Comment #1 from
it ;)
applets/icon/plugin/icon_p.cpp (line 110)
<https://git.reviewboard.kde.org/r/125118/#comment59311>
Nitpick: Assert that dropEvent isn't a nullptr instead. (A drop without a
drop event shouldn't happen, right? ;)
- Emmanuel Pescosta
On Sept. 9, 2015, 9:14 p.m., Ka
tps://git.reviewboard.kde.org/r/125118/#comment58863>
A DeclarativeDropEvent::toQDropEvent() method maybe?
- Emmanuel Pescosta
On Sept. 9, 2015, 9:14 p.m., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125118/#review85129
---
Looks good to me, +1
- Emmanuel Pescosta
On Sept. 9, 2015
)
And thanks for this nice feature :)
- Emmanuel Pescosta
On Sept. 8, 2015, 8:37 p.m., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://gi
marked as submitted.
Review request for Plasma and Kai Uwe Broulik.
Changes
---
Submitted with commit 08cbba07eb8927ce3a0f864eda8dfe1f8f1a6e44 by Emmanuel
Pescosta to branch Plasma/5.3.
Repository: plasma-workspace
Description
---
Fix a crash in PowermanagementEngine
/
Testing
---
Thanks,
Emmanuel Pescosta
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
tps://git.reviewboard.kde.org/r/123164/#comment53583>
array.filter() maybe?
src/applet/package/contents/code/logic.js (line 52)
<https://git.reviewboard.kde.org/r/123164/#comment53584>
array.forEach() maybe?
- Emmanuel Pescosta
On March 29, 2015, 10:13 p.m., David
https://bugs.kde.org/show_bug.cgi?id=345440
Emmanuel Pescosta changed:
What|Removed |Added
Version|4.13.3 |unspecified
Product|dolphin
://git.reviewboard.kde.org/r/121447/,
please test it with the latest KIO release.
- Emmanuel Pescosta
On March 10, 2015, 11:18 p.m., Rajeesh K Nambiar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
is only possible using
> > the keyboard".
> >
> > That way, it's not possible to maneuver yourself in an unrecoverable
> > position but people who like to switch off their screen backlight can still
> > do so using the keyboard. And we don't need to
is only possible using
> > the keyboard".
> >
> > That way, it's not possible to maneuver yourself in an unrecoverable
> > position but people who like to switch off their screen backlight can still
> > do so using the keyboard. And we don't need to
> zero. It's exactly the same thing as with "mute" functions on volume
> controls. They do the same as setting the volume to zero, but
> a) It's quicker
> b) You get your previous volume setting back after un-muting
>
> Martin Klapetek wrote:
> But
> On Feb. 10, 2015, 10:01 a.m., Mark Gaiser wrote:
> > I'm not quite sure if a user wants to see a warning message at all.
> > When i use my notebook in a dark environment i usually put the brightness
> > all the way down (depending on the notebook).
>
> Kai Uwe Broulik wrote:
> As I stated
> On Feb. 11, 2015, 12:50 a.m., Thomas Pfeiffer wrote:
> > Basic rule from design for safety: Don't use a warning if you can prevent
> > the dangerous action completely.
> > In this case that means: Setting the brightness to zero should only be
> > possible via keyboard, because that ensures re
of such problems in my summer job)
if (service) {
...
} else {
*prettyName = name;
*icon = QString();
}
- Emmanuel Pescosta
On Jan. 19, 2015, 8:02 p.m., Kai Uwe Broulik wrote:
>
> ---
> This is a
tps://git.reviewboard.kde.org/r/122132/#comment51567>
Oh I see why you have added the check, line 301.
What about setting prettyName to name if no service was found? So
prettyName always has a valid value.
- Emmanuel Pescosta
On Jan. 18, 2015, 10:19 p.m., Kai Uwe Broulik
me).toString(); (the name
property can't be null according to KService, so you can also pass on
QVariant::Invalid as default value instead)
dataengines/powermanagement/powermanagementengine.cpp
<https://git.reviewboard.kde.org/r/122132/#comment51564>
*icon = service->icon
/#comment50229>
Please make use of QMutableListIterator
applets/notifications/plugin/notificationshelper.cpp
<https://git.reviewboard.kde.org/r/121360/#comment50230>
Removing from m_queue also has to be locked, so move it before the Q_FOREACH
- Emmanuel Pescosta
O
> On Dec. 4, 2014, 10:20 p.m., Emmanuel Pescosta wrote:
> > dataengines/powermanagement/powermanagementengine.cpp, line 170
> > <https://git.reviewboard.kde.org/r/121355/diff/1/?file=331906#file331906line170>
> >
> > You can remove the "this&quo
tps://git.reviewboard.kde.org/r/121355/#comment49826>
You can remove the "this" receiver here and in other connect calls.
- Emmanuel Pescosta
On Dec. 4, 2014, 9:41 p.m., Kai Uwe Broulik wrote:
>
> ---
> This is a
27;t think so.
Code looks good and thanks for polishing plasma on such a detailed level :)
- Emmanuel Pescosta
On Nov. 11, 2014, 6:50 p.m., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail. To
/NotificationItem.qml
<https://git.reviewboard.kde.org/r/120997/#comment48907>
d >= x checks are useless
- Emmanuel Pescosta
On Nov. 4, 2014, 10:33 p.m., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mai
f501ded
Diff: https://git.reviewboard.kde.org/r/120151/diff/
Testing
---
Still compiles
Thanks,
Emmanuel Pescosta
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
compiles
Thanks,
Emmanuel Pescosta
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
tps://git.reviewboard.kde.org/r/119794/#comment45199>
really?! ;)
lookandfeel/contents/components/KeyboardLayout.qml
<https://git.reviewboard.kde.org/r/119794/#comment45200>
Maybe a simple modulo operation instead of this check?
- Emmanuel Pescosta
On Aug. 14, 2014, 11:40 p.m.
:
Is it possible to support row + column layouts, depending on the available
height?
The row layout (with show date enabled) has some problems with narrow
horizontal panels.
- Emmanuel Pescosta
On Aug. 14, 2014, 8:28 p.m., Dan Vrátil wrote
g/r/118148/#comment41634>
Please add a break; after this line.
- Emmanuel Pescosta
On May 22, 2014, 4:59 p.m., Vishesh Handa wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.rev
> On April 9, 2014, 1:27 p.m., Marco Martin wrote:
> > I like the idea, only two things:
> > * I am not sure about the default, would rather have it empty so everybody
> > that doesn't set it goes in a "misc" section
> > * if this goes in, i would like to see sprinter's querymatch have the same,
tps://git.reviewboard.kde.org/r/116907/#comment37608>
m_volume = qBound(0.0, volume, 1.0);
Maybe?
- Emmanuel Pescosta
On March 19, 2014, 6:22 p.m., Ashish Madeti wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
40 matches
Mail list logo
