> On Dec. 4, 2014, 10:20 p.m., Emmanuel Pescosta wrote: > > dataengines/powermanagement/powermanagementengine.cpp, line 170 > > <https://git.reviewboard.kde.org/r/121355/diff/1/?file=331906#file331906line170> > > > > You can remove the "this" receiver here and in other connect calls. > > Kai Uwe Broulik wrote: > Are you sure? We've had crashes with the connection not being removed > when the receiver was deleted causing the lambda to segfault.
I think that the context destroys all watchers (senders), so all connections should be removed before the context (receiver) is deleted. But always using the sender + context connect to avoid potential sources of crashes is a good idea, definitely something to keep in mind :) Sorry for the noise! - Emmanuel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/#review71367 ----------------------------------------------------------- On Dec. 4, 2014, 9:41 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121355/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 9:41 p.m.) > > > Review request for Plasma and Solid. > > > Repository: plasma-workspace > > > Description > ------- > > Now that we can finally use absolute brightness values, rather than a fixed > 0-100% range, those values should be exposed in the dataengine instead. This > allows us to eg. properly handle keyboard brightness controls which usually > have just a few steps. I adjusted battery monitor accordingly. > > It also cleans up the code by moving stuff into lambdas and gets rid of the > ugly availability stuff by just relying on the maximum values to determin > whether it's available. We still don't have means, though, to detect changes > in these at runtime. > > > Diffs > ----- > > dataengines/powermanagement/powermanagementengine.h ffad13e > dataengines/powermanagement/powermanagementengine.cpp 04aa49b > dataengines/powermanagement/powermanagementjob.cpp c4e4510 > > Diff: https://git.reviewboard.kde.org/r/121355/diff/ > > > Testing > ------- > > Works as expected, I need someone without keyboard or screen brightness to > test the availability. > > > File Attachments > ---------------- > > Battery monitor with keyboard > > https://git.reviewboard.kde.org/media/uploaded/files/2014/12/04/c00db2e1-5278-4a1b-bd32-ff36777b91c6__batterykeyboardsteps.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
