----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122132/#review74278 -----------------------------------------------------------
dataengines/powermanagement/powermanagementengine.cpp <https://git.reviewboard.kde.org/r/122132/#comment51566> inhibitionsChanged(reply.value(), QStringList()) to avoid code duplication? Why the name.isEmpty() check only here? dataengines/powermanagement/powermanagementengine.cpp <https://git.reviewboard.kde.org/r/122132/#comment51565> I think you can remove the "is empty" checks here, because prettyName and icon are empty anyway. dataengines/powermanagement/powermanagementengine.cpp <https://git.reviewboard.kde.org/r/122132/#comment51563> *prettyName = service->property("Name", name).toString(); (the name property can't be null according to KService, so you can also pass on QVariant::Invalid as default value instead) dataengines/powermanagement/powermanagementengine.cpp <https://git.reviewboard.kde.org/r/122132/#comment51564> *icon = service->icon(); - Emmanuel Pescosta On Jan. 18, 2015, 10:19 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122132/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2015, 10:19 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > ------- > > This adds a new "Inhibition" source which has keys for each application > (amarok, vlc, ...) and inside a QVariantMap with the pretty application name > (taken from the desktop file through KService and cached locally), the > application icon and the reason for the inhibition (as provided by the > application) > > > Diffs > ----- > > dataengines/powermanagement/powermanagementengine.h a06fe7a > dataengines/powermanagement/powermanagementengine.cpp 2d370e6 > > Diff: https://git.reviewboard.kde.org/r/122132/diff/ > > > Testing > ------- > > Works well, survives plasma reboots, and can now expose this information to > the user in the battery monitor. > > Adding usability just for feedback on the eventual user representation, see > screenshot. It shows the application icon plus either "Amarok has disabled > power management: Playing music" or in case of multiple inhibitions "Amarok > and n other applications have disabled power management". > > > File Attachments > ---------------- > > In action > > https://git.reviewboard.kde.org/media/uploaded/files/2015/01/18/bd4c4b7c-89de-4ce6-9004-d480c2e1af57__pmdisabled3.png > Updated wording > > https://git.reviewboard.kde.org/media/uploaded/files/2015/01/18/92d2371b-ead1-418f-8670-4fdb82fc4223__pmdisabled4.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
