----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121105/#review70267 -----------------------------------------------------------
Ship it! > he's the container expert I don't think so. Code looks good and thanks for polishing plasma on such a detailed level :) - Emmanuel Pescosta On Nov. 11, 2014, 6:50 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121105/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 6:50 p.m.) > > > Review request for Plasma, Emmanuel Pescosta, Eike Hein, and Martin Klapetek. > > > Repository: plasma-workspace > > > Description > ------- > > This patch makes notifications only show the configure button if the > application actually has configurable notifications, adapted from > KNotifyEventList::fill(). > > > Diffs > ----- > > dataengines/notifications/notificationsengine.h 40155f2 > dataengines/notifications/notificationsengine.cpp 06233e9 > > Diff: https://git.reviewboard.kde.org/r/121105/diff/ > > > Testing > ------- > > Plasmashell's undo notification and NM notifications still have working > configure whereas KMail does not (the dialog was empty previously) > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
