D24407: Increase UI commonality between KCM and applet

mmustac added a comment. Not related to this patch, but... While looking at these screenshots I find it not self-explaining but more confusing that both buttons look the same, except one of them is in "active" state. I would propose to change the icon for the non-default device to an empt

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 428 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/428/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 04 Oct 2019 03:27:26 + Build duration: 1 min 30 sec and counting CONSOLE OUTPUT [...trunca

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 166 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/166/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 04 Oct 2019 03:27:26 + Build duration: 1 min 3 sec and counting CONSOLE OUTPUT [...t

D24408: Use the right icon depending on the layout

ngraham added a comment. Can you share some screenshots? Based on the code I would expect the opposite arrows, but I'm not familiar with this UI. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24408 To: apol, #plasma Cc: ngraham, plasma-devel, LeGast00n, The

D24408: Use the right icon depending on the layout

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY If we're showing the icons in a horizontal layout, the < and > buttons feel like it should be selecting in

D24407: Increase UI commonality between KCM and applet

ngraham updated this revision to Diff 67293. ngraham added a comment. Correct porting error in KCM combobox model generation REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24407?vs=67292&id=67293 BRANCH improve-ui-commonality-between-k

D24407: Increase UI commonality between KCM and applet

ngraham created this revision. ngraham added reviewers: VDG, Plasma, drosca, broulik, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch beings the user interface of the applet and the KCM closer

D22381: Add previous-/nextActivity methods

This revision was automatically updated to reflect the committed changes. muesli marked an inline comment as done. Closed by commit R161:e3a7cb2f1b18: Add previous-/nextActivity methods (authored by muesli). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabrica

D24374: WIP: Initial port of the Date and Time KCM

tcanabrava updated this revision to Diff 67277. tcanabrava added a comment. wq - Restore colors metatada, and correctly set the datetime metadata - s/kcmclock/kcm_clock - Fix author - kcm_name break kauth, it needs kcmname =/ - Fix missing property, Add a Qml Clock (from the Qt Demo

D24393: Switch from naked KConfig to KConfigXT

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24393 To: ervin, #plasma, mart, apol Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D22381: Add previous-/nextActivity methods

muesli updated this revision to Diff 67276. muesli added a comment. Fix typo in 'nameBasedOrdering' REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22381?vs=61590&id=67276 BRANCH prevnext-activity (branched from master) REVISION DETAIL

D22382: Add global shortcuts for switching to the previous/next activity

ngraham added subscribers: romangg, ngraham. ngraham added reviewers: VDG, Plasma. ngraham added a comment. I agree that we should set //some// global shortcut (otherwise there's practically no point; only 0.001% of users ever set custom global shortcuts). No opinions regarding this one thoug

D22382: Add global shortcuts for switching to the previous/next activity

muesli added a comment. In D22382#541626 , @ivan wrote: > I'm not thrilled about having default shortcuts set. We have the shortcuts space quite polluted as it is. I'm happy to remove the defaults (even though I consider them fairly cons

D24276: Add text to speech functionality to klipper.

ndavis added a comment. This seems like a good idea to me REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24276 To: whiting, davidedmundson, gladhorn, #plasma_accessibility, #plasma Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalouka

D22382: Add global shortcuts for switching to the previous/next activity

ivan added a comment. I'm not thrilled about having default shortcuts set. We have the shortcuts space quite polluted as it is. Especially since we have the meta+tab with different semantics. Maybe the text should explicitly state what 'next' means in this case. REPOSITORY R120 Pl

D22381: Add previous-/nextActivity methods

ivan added inline comments. INLINE COMMENTS > Activities.cpp:56 > +inline > +bool nameBaseOrdering(const ActivityInfo &info, const ActivityInfo > &other) > +{ Nitpick Base -> Based > Activities.cpp:251 > + > +for (int i = 0; i < a.count(); ++i) { > +if (a[i] == currentA

D24394: Expose the settings object to QML

mart added inline comments. INLINE COMMENTS > kcm.h:47 > Q_OBJECT > +Q_PROPERTY(DesktopThemeSettings *desktopThemeSettings READ > desktopThemeSettings CONSTANT) > Q_PROPERTY(QStandardItemModel *desktopThemeModel READ desktopThemeModel > CONSTANT) generic api musings: could this b

D24379: [energy kcm] Fix Technology values

meven added a comment. In D24379#541409 , @davidedmundson wrote: > This is already available and translated in solid. > > solid/src/solid/devices/backends/upower/upowerdevice.cpp > 142:return tr("Lithium Ion", "battery technology")

D24392: Turn the config into the single source of truth

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. I investigated a bit where m_defaultTheme comes from. It seems it goes all way back to the old plasma4 version of the kcm, where Theme was a singleton. now there is no need whatsoever for that

D24394: Expose the settings object to QML

ervin created this revision. ervin added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY This simplifies quite a bit the logic, we don't need to do the bookkeeping ourselves anymore. Onl

D24392: Turn the config into the single source of truth

ervin created this revision. ervin added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY The module had a somewhat convoluted logic around the management of its settings. Sometimes it wa

D24393: Switch from naked KConfig to KConfigXT

ervin created this revision. ervin added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY It provides some improvements at least: first in code reuse, but also it cleans up the config fil

D24391: Silence warnings (noops + unused capture variable)

ervin created this revision. ervin added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24391 AFFECTED FILES kcms/desktopt

D24276: Add text to speech functionality to klipper.

whiting added a comment. Does anyone have any opinion on this change? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24276 To: whiting, davidedmundson, gladhorn, #plasma_accessibility, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampal

D24379: [energy kcm] Fix Technology values

meven updated this revision to Diff 67261. meven added a comment. Use enum values for chargeState and technology REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24379?vs=67258&id=67261 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2437

Re: ddcutil in Plasma Powerdevil

I think we are generally backwards compatible to 3.5 or some such, so you'll want to use the old call I guess. FWIW, the more reliable and I think also more liked way of doing this is to configure_file a header where you #cmakedefine WITH_DDCUTI e.g. see plasma-workspace or plasma-desktop. That wo

D24371: [KCM] Make the warning message wider

This revision was automatically updated to reflect the committed changes. Closed by commit R104:f926adc3309e: [KCM] Make the warning message wider (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24371?vs=67216&id=67259#toc REPOSITORY R104 KScreen CHANGES SINCE LA

D24379: [energy kcm] Fix Technology values

meven updated this revision to Diff 67258. meven added a comment. Fix enum values REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24379?vs=67240&id=67258 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24379 AFFECTED FILES Modules/ene

D24265: support global edit mode

GB_2 added a comment. A few bugs I found: - when you open the desktop context menu it enters the edit mode automatically (probably because it thinks you still click) - after closing the panel controller or "Add Widgets..." sidebar it closes the edit mode too REPOSITORY R119 Plasma D

D24379: [energy kcm] Fix Technology values

davidedmundson added a comment. This is already available and translated in solid. solid/src/solid/devices/backends/upower/upowerdevice.cpp 142:return tr("Lithium Ion", "battery technology"); Can't we expose that instead of duplicating things in QML. Especially with horrifi

D24299: Fix "Show intro page" button not resetting titlebar title

GB_2 added a comment. In D24299#539868 , @ngraham wrote: > this doesn't work for the case of clicking on one of the categories shown on the home page and then clicking on the home button. You're right, maybe @mart can help :-) REPOSITORY

D24379: [energy kcm] Fix Technology values

alexde added a comment. As this it not in the scope of this patch, those values look suspicious to me too: switch(model.battery.type) { case 3: return i18n("Internal battery") case 2: return i18n("UPS battery") case 9: return i18n("Monitor battery") case 4: return i18n("