ivan added inline comments.
INLINE COMMENTS
> Activities.cpp:56
> + inline
> + bool nameBaseOrdering(const ActivityInfo &info, const ActivityInfo
> &other)
> + {
Nitpick Base -> Based
> Activities.cpp:251
> +
> + for (int i = 0; i < a.count(); ++i) {
> + if (a[i] == currentActivity) {
Can be done with `std::find_if` as well
> Activities.cpp:333
>
> + for (int i = 0; i < sortedActivities.count(); ++i) {
> + if (sortedActivities[i].id == activity) {
This can be done with `std::find_if` and then remove with iterator.
REPOSITORY
R161 KActivity Manager Service
REVISION DETAIL
https://phabricator.kde.org/D22381
To: muesli, ivan
Cc: ivan, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
