ngraham created this revision. ngraham added reviewers: VDG, Plasma, drosca, broulik, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision.
REVISION SUMMARY This patch beings the user interface of the applet and the KCM closer together. To accomplish this, the following changes are made: - Move the "Default Device" button onto the first row in the applet and make it a ToolButton to reduce its visual weight - In both the applet and the KCM, show the port chooser UI in combobox form only when multiple ports are available; otherwise show only a text label. This is allowed by the HIG because it is a case of hardware availability (https://hig.kde.org/plattform/settings.html?highlight=inapplicable#behavior) Depends on D24402 <https://phabricator.kde.org/D24402> TEST PLAN Simple case: F7509998: Simple case.png <https://phabricator.kde.org/F7509998> More complex case: F7509997: Complex case.png <https://phabricator.kde.org/F7509997> REPOSITORY R115 Plasma Audio Volume Applet BRANCH improve-ui-commonality-between-kcm-and-applet (branched from master) REVISION DETAIL https://phabricator.kde.org/D24407 AFFECTED FILES applet/contents/ui/ListItemBase.qml src/kcm/package/contents/ui/DeviceListItem.qml To: ngraham, #vdg, #plasma, drosca, broulik, sitter Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart