ervin created this revision. ervin added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision.
REVISION SUMMARY The module had a somewhat convoluted logic around the management of its settings. Sometimes it was reading through Plasma::Theme (mostly proxying in some form what was in the config), sometimes straight from KConfig. We now got rid of m_defaultTheme to avoid the temptation of reading from it, KConfig is our only source of settings. We kept a single call to Plasma::Theme on save, but that's simply to ensure proper signalling of the change to the running shell. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24392 AFFECTED FILES kcms/desktoptheme/kcm.cpp kcms/desktoptheme/kcm.h To: ervin, #plasma, mart Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart