D3484: Center systemmonitor window properly on multi-screen setup

broulik added inline comments. INLINE COMMENTS > valeriymalov wrote in ksystemactivitydialog.cpp:79 > Yes, per my interpretation of the comment that application shouldn't force > it's window properties like that because it interferes with WM settings. > > There doesn't really seem to be a conse

D15086: Fix localization of QML code

This revision was automatically updated to reflect the committed changes. Closed by commit R846:164602da8171: Fix localization of QML code (authored by yurchor). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15086?vs=40460&id=40531#toc REPOSITORY R846 Mycroft Plasma integration CHANG

D15110: Fix scrollbars in LibreOffice

gepardo created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gepardo requested review of this revision. REVISION SUMMARY BUG: 389709 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D15110 AFFECTED FILES Breeze-gtk/gtk-

D15024: Update icons kcm docbook to 5.13

lueck updated this revision to Diff 40526. lueck added a comment. fix issues spotted by pino, thanks REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15024?vs=40304&id=40526 REVISION DETAIL https://phabricator.kde.org/D15024 AFFECTED FILES doc/kc

D3484: Center systemmonitor window properly on multi-screen setup

valeriymalov added inline comments. INLINE COMMENTS > broulik wrote in ksystemactivitydialog.cpp:79 > Is it intentional you removed the `KeepAbove`? Yes, per my interpretation of the comment that application shouldn't force it's window properties like that because it interferes with WM settings

D14389: Invert shade button by same logic as keep-above button

ngraham added a comment. In D14389#316227 , @hpereiradacosta wrote: > IMHO: you should either > > - keep the same icon, use the invert-color to set active state (meaning: remove the "unshade" icon > - keep to different icons, and not inver

D15101: [Widget Explorer] always show the search field

abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. Approved depending on the code review. REPOSITORY R119 Plasma Desktop BRANCH widget-explorer-always-shows-search-field (branched from master) REVISION DETAIL https://phabricator.kde.

D14389: Invert shade button by same logic as keep-above button

hpereiradacosta added a comment. IMHO: you should either - keep the same icon, use the invert-color to set active state (meaning: remove the "unshade" icon - keep to different icons, and not invert-color (in which case the active state is driven by the drawn icon) but not both.

D15101: [Widget Explorer] always show the search field

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15101 To: ngraham, #plasma, sharvey, #vdg Cc: abetts, sharvey, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15024: Update icons kcm docbook to 5.13

pino added inline comments. INLINE COMMENTS > index.docbook:48 > > + > In this module you can: extra empty line > index.docbook:86 > > -If you dowloaded new themes from the internet, you can use this to browse to > the > -location of those newly downloaded themes. Clicking on this button

D15024: Update icons kcm docbook to 5.13

lueck added a comment. In D15024#314116 , @abetts wrote: > I am hoping there is also a way for people to be able to see more information about the theme in GHNS. Is there a visual way that we can do this? Maybe do the layout the same as it was b

SCSS sources of Breeze-gtk

Hello, I noticed that Breeze-gtk theme had SCSS sources in https://github.com/dirruk1/gnome-breeze. But now this repository is adandoned, and the KDE repos don't include SCSS sources. Does anyone knows why this happened? Because of lack of sources, Breeze-gtk and Breeze-Dark-gtk are not syncron

D3484: Center systemmonitor window properly on multi-screen setup

broulik added inline comments. INLINE COMMENTS > ksystemactivitydialog.cpp:79 > -if (keepAbove) { > -KWindowSystem::setState(winId(), NET::KeepAbove); > -} Is it intentional you removed the `KeepAbove`? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kd

D15011: [Kickoff] Make the search field always look like a search field

abetts added a comment. Yay! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson, abetts Cc: fabianr, huftis, rooty, sharvey, romangg, broulik, safaalfulaij, oysteins, filipf, abetts, davidedmundson, michaeltunnell

D15011: [Kickoff] Make the search field always look like a search field

ngraham added a comment. Submitted a patch to make Widget Explorer consistent and always show the search field: D15101 . If that patch and this one both land, then the columns two and three in the table above will be entirely full of "Yes" values! REPOSIT

D15101: [Widget Explorer] always show the search field

ngraham created this revision. ngraham added reviewers: Plasma, sharvey. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Most Plasma widgets and apps that have search fields show them by default. Two exceptions

D12855: Move Widget search field to its own row so it doesn't get compressed

This revision was automatically updated to reflect the committed changes. Closed by commit R119:08983522bfb4: Move Widget search field to its own row so it doesn't get compressed (authored by sharvey). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1285

D12311: Align lock icon with bold message text; reduce overall size of dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R121:d4ee26a76a21: Align lock icon with bold message text; reduce overall size of dialog (authored by sharvey). REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricato

D14695: disable title for QML kcms

mart updated this revision to Diff 40503. mart added a comment. - use setHeaderVisible REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14695?vs=39318&id=40503 BRANCH arcpatch-D14695 REVISION DETAIL https://phabricator.kde.org/D14695 AFFECTED

D14581: support for multilevel kcms

mart updated this revision to Diff 40502. mart added a comment. - use the new api KPageWidgetItem::setHeaderVisible REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14581?vs=39312&id=40502 BRANCH arcpatch-D14581 REVISION DETAIL https://phabricat

D15093: Add WireGuard capability.

anthonyfieroni added a comment. When you use background-color you combine with QPalette, at least, because you break all other themes. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D15093 To: andersonbruce, #plasma, jgrulich, pino Cc: antho

D14855: Add applet with screen layouts and presentation mode

dhaumann added a comment. @broulik Could we clarify the copyright? INLINE COMMENTS > kscreenapplet.h:3-4 > + * Copyright (c) 2018 Kai Uwe Broulik > + *Work sponsored by the LiMux project of > + *the city of Munich. > + * Hi Kai. Imo this copyright is

D15093: Add WireGuard capability.

jgrulich added a comment. That's a big change/patch, I'll look more closely as soon as possible. One thing I see at first look is different coding style, can you please follow Qt coding style? I'm sure that many parts of plasma-nm are not using consistent coding style, but you should try to

Monday meeting notes for 27/08/2018

Kai Uwe: Work done: ‎ - Created an AppImage thumbnailer ‎ - Fixed Plasma IconItem not reloading when KIconTheme changes (when it's using a QIcon) ‎ - Fixed freeze when pressing media keys with unresponsive player (blocking dbus calls) ‎ - Fixed crash when switching between Grid QML KCMs, Qt bug,

[Powerdevil] [Bug 367648] Dim Screen time in Energy Saving Settings is wrong

https://bugs.kde.org/show_bug.cgi?id=367648 SorenHN changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in soliddeviceengine.cpp:555 > I think you can just move the notification to > > connect(job, &KIO::FileSystemFreeSpaceJob::result, ...) { > > if (job->error() == ERR_SERVER_TIMEOUT) { > > > > } > } > > but I haven't

D6096: Add Wayland RemoteAccess capabilities to KRfb

jgrulich added a comment. Now I realized what you mean, you mean that I didn't change libspa version as I did for pipewire, right? That hasn't change in released PW tarballs, but it's already changed now in master (Wim started versioning it) so I will have to fix this as well. REPOSITORY

D6096: Add Wayland RemoteAccess capabilities to KRfb

jgrulich added a comment. In D6096#315732 , @Kanedias wrote: > @jgrulich you didn't change FindSPA, is it ok? I assume it is correct now, I got some fixes from Christophe Giboudeaux. REPOSITORY R437 Desktop Sharing REVISION DETAIL htt