McPain added inline comments. INLINE COMMENTS
> davidedmundson wrote in soliddeviceengine.cpp:555 > I think you can just move the notification to > > connect(job, &KIO::FileSystemFreeSpaceJob::result, ...) { > > if (job->error() == ERR_SERVER_TIMEOUT) { > > .... > > } > } > > but I haven't tested that. I did. Job will never finish in that case REVISION DETAIL https://phabricator.kde.org/D14895 To: McPain, broulik, ngraham, davidedmundson Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart