jgrulich added a comment.
That's a big change/patch, I'll look more closely as soon as possible. One thing I see at first look is different coding style, can you please follow Qt coding style? I'm sure that many parts of plasma-nm are not using consistent coding style, but you should try to follow this one https://wiki.qt.io/Qt_Coding_Style. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D15093 To: andersonbruce, #plasma, jgrulich, pino Cc: pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
