hpereiradacosta added a comment.
IMHO: you should either - keep the same icon, use the invert-color to set active state (meaning: remove the "unshade" icon - keep to different icons, and not invert-color (in which case the active state is driven by the drawn icon) but not both. Right now when I shade a window, I see an "unshade" icon, which appears as toggled. What am I suppose to expect when I click on it ? Will it "uncheck" the "unshade state" (meaning go to "shade") ? But then my window is shaded ... confusion. This is a regression. Note that I am fine with either solution (1, or 2). Not with the current which is the sum of the two. Hugo (former maintainer). REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D14389 To: andykluger, #breeze, ngraham, #vdg Cc: hpereiradacosta, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
