D14905: Warn on logout screen when another user is logged in

broulik added a comment. In D14905#310978 , @davidedmundson wrote: > When do we want unused sessions? Not sure. Does it recycle them or discard them after a while? They keep piling up usually .. REPOSITORY R120 Plasma Workspace REVIS

D14905: Warn on logout screen when another user is logged in

davidedmundson added a comment. When do we want unused sessions? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14905 To: broulik, #plasma, #vdg, harmathy Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreut

D14905: Warn on logout screen when another user is logged in

ngraham added a comment. Big +1 for the concept. Only one string change proposal, down below: INLINE COMMENTS > Logout.qml:147 > +font.italic: true > +text: i18ndp("plasma_lookandfeel_org.kde.lookandfeel", "One > other user is currently logged in.", > +

D14905: Warn on logout screen when another user is logged in

broulik created this revision. broulik added reviewers: Plasma, VDG, harmathy. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since we have a unified screen for logging out and shutting down, the hint is alway

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

davidedmundson added a comment. Much nicer! I'm definitely happy merging something like this. INLINE COMMENTS > soliddeviceengine.cpp:555 > +if (!m_paths.contains(path)) { > +QTimer *timer = new QTimer(this); > +timer->setSingleShot(true); not sure you need this timer 1.

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 39934. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=39933&id=39934 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengines/soliddevice/CMakeLists.txt dataengines/soliddevice/soliddeviceengine.cpp dataengines/

D14869: [RFC] Increase default font sizes by 1 pt

filipf added a comment. Except it doesn't really boil down to personal preference, unless we're taking eyesight into the equation. 11pt does not just make the fonts look somewhat big, but also increases UI elements, most notably the titlebar (and its buttons) and Kickoff. This is why 13

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 39933. McPain marked 4 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=39929&id=39933 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengines/soliddevice/CMakeLists.txt dataengines/solidde

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added inline comments. INLINE COMMENTS > anthonyfieroni wrote in soliddeviceengine.cpp:564 > You can remove it, see below. What if it creates another job working on the same path? The purpose is "check if nobody is working on path", not "save the timer pointer" > anthonyfieroni wrote i

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

anthonyfieroni added inline comments. INLINE COMMENTS > soliddeviceengine.cpp:588 > +// start timer: after 15 seconds we will get an error > +timer->start(15000); > } job->start(); as well. REVISION DETAIL https://phabricator.kde.org/D14895 To: McPain, broulik, ngraham,

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

anthonyfieroni added inline comments. INLINE COMMENTS > soliddeviceengine.cpp:564 > + > +m_timers[path] = timer; > + You can remove it, see below. > soliddeviceengine.cpp:574 > +connect(job, &KIO::FileSystemFreeSpaceJob::result, > +[this, path, udi](KIO::Job *job

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 39929. McPain added a comment. Used KIO::FileSystemFreeSpaceJob CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=39901&id=39929 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengines/soliddevice/CMakeLists.txt

D14898: Create shadow tiles on demand

This revision was automatically updated to reflect the committed changes. Closed by commit R31:cc24d25a5962: [kstyle] Create shadow tiles on demand (authored by broulik). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14898?vs=39908&id=39926 REVISION DETAIL h

D14898: Create shadow tiles on demand

zzag added a comment. Also, please prepend "[kstyle]" to the title. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D14898 To: broulik, #plasma, ngraham, zzag Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14898: Create shadow tiles on demand

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. In D14898#310731 , @broulik wrote: > I found Breeze's `ShadowHelper::loadConfig()` stick out in hotspot on Dolphin startup, so I investigated what

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

broulik added a comment. It is just a question. I think since you call `setData` when the job finishes anyway, it should be fine but I don't really know the architecture of that stuff either, so it might be fine to just trigger a free space job in `updateSourceEvent` REVISION DETAIL https

D14898: Create shadow tiles on demand

broulik added a comment. I found Breeze's `ShadowHelper::loadConfig()` stick out in hotspot on Dolphin startup, so I investigated what it did and found it would needlessly load the shadows. > It's hard to see them because of low contrast. Right, didn't look closely enough. They stil

D14898: Create shadow tiles on demand

zzag added a comment. > MDI windows don't have any shadows here but that is also without this patch No, they have: F6201521: Screenshot_20180817_145704.png It's hard to see them because of low contrast. REPOSITORY R31 Breeze REVISION DE

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added a comment. In D14895#310633 , @broulik wrote: > Might not be an issue as you call `setData` anyway but just something I want you to keep in mind for testing. something like setData(udi, I18N_NOOP("Free Space"), QVarian

D14898: Create shadow tiles on demand

zzag added a comment. > Breeze spent 70ms What computer are you using? What shadow size? What typical load on your computer? What value of the mean? What value of the standard deviation? Is it debug build or release build? How did you measure that? REPOSITORY R31 Breeze REVISION DETA

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added a comment. In D14895#310633 , @broulik wrote: > Might not be an issue as you call `setData` anyway but just something I want you to keep in mind for testing. I REVISION DETAIL https://phabricator.kde.org/D14895 To: McPain

D14423: Mingw compile fix

This revision was automatically updated to reflect the committed changes. Closed by commit R871:7251f8234730: Mingw compile fix (authored by habacker). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14423?vs=38563&id=39916 REVISION DETAIL https://phabricator

D14423: Mingw compile fix

habacker added a comment. For the record: This patch is used to cross build drkonqi for windows at https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF547/mingw32-drkonqi5 REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.

D14737: Move "update" button from the left side to the right side in NIC module

ngraham closed this revision. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D14737 To: schampailler, ngraham Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14737: Move "update" button from the left side to the right side in NIC module

ngraham added a comment. Thanks for updating this with arcanist. Works like a dream now. :) REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D14737 To: schampailler, ngraham Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, a

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added a comment. In D14895#310633 , @broulik wrote: > Also beware that `bool SolidDeviceEngine::updateSourceEvent` is currently supposed to return `true` Who will use that `true`? I didn't found any places where that value is use

D14737: Move "update" button from the left side to the right side in NIC module

schampailler updated this revision to Diff 39915. schampailler retitled this revision from "Move "update" button from the left side to the right side in NIC module " to "Move "update" button from the left side to the right side in NIC module". schampailler added a comment. D14737

D14423: Mingw compile fix

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. For me it seems ok :) I can't test it. > +2 I trust you :) === REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D14423

D14855: Add applet with screen layouts and presentation mode

broulik added inline comments. INLINE COMMENTS > gladhorn wrote in daemon.h:66 > Could this be unified in some nice way with the above function > (applyOsdAction) which does the same based on the enum...? Maybe just use the > enum, or is there a reason for using a string here but not in other p

D14855: Add applet with screen layouts and presentation mode

gladhorn added a comment. This looks generally nice, I like it. Since we're short on people maintaining this stuff, I'd like more of the code to be shared though. INLINE COMMENTS > daemon.h:66 > +// DBus > +void applyLayoutPreset(const QString &presetName); > Q_SIGNALS:

D14898: Create shadow tiles on demand

broulik created this revision. broulik added reviewers: Plasma, ngraham, zzag. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Breeze spent 70ms on every application startup loading the shadow tiles, despite th

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

broulik added a comment. Yes, please use `KIO::FileSystemFreeSpaceJob` which is a lot simpler than all of this manually added threading code. Also beware that `bool SolidDeviceEngine::updateSourceEvent` is currently supposed to return `true` for when any of the sources changed which will

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. But the KIO stuff is already there. > We can always do it later That's never how it works. REVISION DETAIL https://phabricator.kde.org/D14895 To: McPai

D14857: Label job notifications with destination file name

This revision was automatically updated to reflect the committed changes. Closed by commit R120:499d145e1a36: Label job notifications with destination file name (authored by karthikp, committed by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D14869: [RFC] Increase default font sizes by 1 pt

davidedmundson added a comment. This is exactly the sort of topic that will benefit from the telemetary data that we will hopefully start to have soon. Then we can back things up with facts. Otherwise it can come across as "my personal preference is blah" - and whilst that's exactly how

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added a comment. In D14895#310535 , @davidedmundson wrote: > Thanks for looking into this. > > Whilst this looks fine, we have a more standard abstraction layer for async IO via KIO. > There's a FileSystemFreeSpaceJob which should

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 39901. McPain marked 3 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=39897&id=39901 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengines/soliddevice/CMakeLists.txt dataengines/solidde

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

anthonyfieroni added inline comments. INLINE COMMENTS > soliddeviceengine.cpp:67 > +KDiskFreeSpaceInfo info = KDiskFreeSpaceInfo::freeSpaceInfo(m_path); > +emit infoObtained(m_path, m_udi, info.isValid(), info.available(), > info.size()); > +} Don't you forget to emit finished? > solid

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

davidedmundson added a comment. Thanks for looking into this. Whilst this looks fine, we have a more standard abstraction layer for async IO via KIO. There's a FileSystemFreeSpaceJob which should work here. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 39897. McPain added a comment. Removed useless debug string REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=39896&id=39897 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengi

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain created this revision. McPain added reviewers: broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY BUG: 397537 Earlier plasmashell assumed that you'll get free space info immediately (w