McPain added a comment.

  In D14895#310633 <https://phabricator.kde.org/D14895#310633>, @broulik wrote:
  
  > Also beware that `bool SolidDeviceEngine::updateSourceEvent` is currently 
supposed to return `true`
  
  
  Who will use that `true`?
  I didn't found any places where that value is used.
  
  The only place I found ignores it:
  
    void SolidDeviceEngine::deviceChanged(const QString& udi, const QString 
&property, const QVariant &value)
    {
        setData(udi, property, value);
        updateSourceEvent(udi);
    }

REVISION DETAIL
  https://phabricator.kde.org/D14895

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to