McPain added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in soliddeviceengine.cpp:564
> You can remove it, see below.

What if it creates another job working on the same path?

The purpose is "check if nobody is working on path", not "save the timer 
pointer"

> anthonyfieroni wrote in soliddeviceengine.cpp:588
>   job->start();
> 
> as well.

Job starts without it

REVISION DETAIL
  https://phabricator.kde.org/D14895

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to