zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land.
In D14898#310731 <https://phabricator.kde.org/D14898#310731>, @broulik wrote: > I found Breeze's `ShadowHelper::loadConfig()` stick out in hotspot on Dolphin startup, so I investigated what it did and found it would needlessly load the shadows. Well, I wouldn't trust hotspot/perf in this case. Creation of kstyle shadows is pretty cheap so I think that's fine to create them on demand (in contrast to decoration shadows, which are pretty heavy). Anyway, codewise, patch looks okay to me. Please delete "70ms" in the summary because that number doesn't mean anything. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D14898 To: broulik, #plasma, ngraham, zzag Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
