D12248: [Desktop Theme KCM] Port to new design

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6ecb40efcd7e: [Desktop Theme KCM] Port to new design (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12248?vs=32299&id=32363 REVISION

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

ngraham marked an inline comment as done. ngraham added a comment. ...Gotta make sure that cancel slot actually works, so this is now dependent on my patch that fixes it: D12227 REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

ngraham marked 2 inline comments as done. ngraham added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kdeplatformfiledialoghelper.cpp:108 > Even better to me should be > > connect(this, &KDEPlatformFileDialog::rejected, m_fileWidget, > &KFileWidget::slotCancel); > > PS: You can

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

ngraham updated this revision to Diff 32361. ngraham added a comment. Use a vastly cleaner and cleverer approach (thanks @anthonyfieroni) REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12240?vs=32338&id=32361 BRANCH save

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

anthonyfieroni added inline comments. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:108 > m_buttons->addButton(m_fileWidget->cancelButton(), > QDialogButtonBox::RejectRole); > connect(m_buttons, SIGNAL(rejected()), m_fileWidget, SLOT(slotCancel())); > connect(m_fileWidget->okB

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

anthonyfieroni added inline comments. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:243 > +{ > +m_fileWidget->writeViewConfig(); > +QDialog::reject(); You can see at line 108 on reject is called slotCancel, so for convenience just call it m_fileWidget->slotCancel(); Then you can

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

ngraham added a comment. Perhaps we could indeed make use of `QSize::boundedTo()` to make sure that no dimension of the minimum size is ever bigger than a dimension of the current screen size. That would help folks like Christoph with his 768x1024 vertical screen. I really think a mini

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

cfeck added inline comments. INLINE COMMENTS > SettingsBase.cpp:128 > + > +// enforce minimum window size > +setMinimumSize(SettingsBase::sizeHint()); Why? I use some systems in portrait mode, 768x1024 pixels. REPOSITORY R124 System Settings BRANCH enlarge-default-size (branched fr

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey updated this revision to Diff 32351. sharvey added a comment. - Add `const`, revise scale factoring for Qt rounding REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12252?vs=32343&id=32351 BRANCH enlarge-default-size (branched from master)

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

zzag added inline comments. INLINE COMMENTS > SettingsBase.cpp:82 > +// calculate base window size to an appropriate size > +qreal factor = QGuiApplication::primaryScreen()->devicePixelRatio(); > +return QSize(1024*factor, 768*factor); You forgot `const`. Also, you could multiply wh

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey updated this revision to Diff 32343. sharvey added a comment. - Revert back to 700 for Y scale REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12252?vs=32341&id=32343 BRANCH enlarge-default-size (branched from master) REVISION DETAIL ht

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

ngraham added a comment. In D12252#247757 , @zzag wrote: > These defaults are really big, especially height. What about folks with 1366x768 screen resolution? http://gs.statcounter.com/screen-resolution-stats/desktop/worldwide The issue

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

ngraham added a comment. KWin adds a titlebar to the chosen window size that is itself of variable height depending on the titlebar font size. So if we want to maintain compatibility with an actual 1024x768 display, we'll need to at reduce our minimum height by 30 px or so--possibly more. Mi

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

zzag added a comment. These defaults are really big, especially height. What about folks with 1366x768 screen resolution? http://gs.statcounter.com/screen-resolution-stats/desktop/worldwide REPOSITORY R124 System Settings BRANCH enlarge-default-size (branched from master) REVISION DETA

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey added a comment. > Heh, that wasn't a request targeted at you, but rather a question for others. :) Should I back those 68 pixels back out (for now?) REPOSITORY R124 System Settings BRANCH enlarge-default-size (branched from master) REVISION DETAIL https://phabricator.kde

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

ngraham added a comment. In D12252#247750 , @sharvey wrote: > In D12252#247745 , @ngraham wrote: > > > Ah, so it is! Any objections to increasing the effective minimum size to 1024x768? It seems tha

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey added a comment. In D12252#247745 , @ngraham wrote: > Ah, so it is! Any objections to increasing the effective minimum size to 1024x768? It seems that this is the size that the KCMs were actually designed for, so it makes sense to me as

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey updated this revision to Diff 32341. sharvey added a comment. - Tweak size to 1024x768 REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12252?vs=32337&id=32341 BRANCH enlarge-default-size (branched from master) REVISION DETAIL https://ph

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah, so it is! Any objections to increasing the effective minimum size to 1024x768? It seems that this is the size that the KCMs were actually designed for, so it makes sense to me as a se

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey added a comment. > All of this is already implemented and works as expected if you simply remove the `resize()` call. What needs to be done is to specify the default size without always calling `resize()`. Either that, or enforce 1024x700 as the minimum. Well then it's already i

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

ngraham added a comment. In D12252#247719 , @sharvey wrote: > I thought about that. I figured there wasn't any harm in letting the user resize the window even if it wouldn't be saved. User-chosen window sizes should //always// be saved. T

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

ngraham updated this revision to Diff 32338. ngraham added a comment. Fix typo REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12240?vs=32236&id=32338 BRANCH save-view-config-on-close-and-escape (branched from master) RE

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey added a comment. > Once that's fixed, there's still one more issue here: always calling `resize()` this means that once the user resizes the window, that custom size will be overridden on the next launch. We want to set a better default size, not enforce a mandatory size. I wonder if

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey updated this revision to Diff 32337. sharvey added a comment. - Remove qBound and division by 96 for pixel ratio REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12252?vs=32336&id=32337 BRANCH enlarge-default-size (branched from master) RE

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

ngraham added inline comments. INLINE COMMENTS > SettingsBase.cpp:82 > +// calculate base window size to an appropriate size > +qreal factor = qBound(1.0, > QGuiApplication::primaryScreen()->devicePixelRatio()/96., 3.0); > +return QSize(1024*factor, 700*factor); you don't need to di

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey updated this revision to Diff 32336. sharvey added a comment. - Use `devicePixelRatio` for base size instead of `physicalDotsPerInch` REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12252?vs=32323&id=32336 BRANCH enlarge-default-size (bran

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

ngraham added a comment. I think I found the problem: `physicalDotsPerInch()` is not the correct property to be checking here, as it will vary depending on the display's pixel density. You want to change that to check `devicePixelRatio()` instead. That gives me perfect results. Once th

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

elvisangelaccio added inline comments. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:240 > +// Save the view settings before closing the dialog when the Escape key > +// is presed or the close button in the titlebar is clicked > +void KDEPlatformFileDialog::reject() typo: pressed REPOSITORY

D12263: [kstyle] don't suppress deprecation warnings

zzag created this revision. zzag added reviewers: Breeze, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R31 Breeze BRANCH dont-suppress-deprecated-warnings REVISION

D12261: [kstyle] drop QStyleOptionFrameV3 in Qt 5 style plugin

zzag created this revision. zzag added reviewers: Breeze, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R31 Breeze BRANCH drop-QStyleOptionFrameV3 REVISION DETAIL

D12262: [kstyle] drop QStyleOptionDockWidgetV2 in Qt 5 style plugin

zzag created this revision. zzag added reviewers: Breeze, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R31 Breeze BRANCH drop-QStyleOptionDockWidgetV2 REVISION DETA

D12260: [kstyle] drop QStyleOptionFrameV2 in Qt 5 style plugin

zzag created this revision. zzag added reviewers: Breeze, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R31 Breeze BRANCH drop-QStyleOptionFrameV2 REVISION DETAIL

D12259: [kstyle] drop QStyleOptionViewItemV4 in Qt 5 style plugin

zzag created this revision. zzag added reviewers: Breeze, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R31 Breeze BRANCH drop-QStyleOptionViewItemV4 REVISION DETAIL

D12258: [kstyle] drop QStyleOptionTabWidgetFrameV2 in Qt 5 style plugin

zzag created this revision. zzag added reviewers: Breeze, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R31 Breeze BRANCH drop-QStyleOptionTabWidgetFrameV2 REVISION

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

zzag created this revision. zzag added reviewers: Breeze, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY D11566 is now in KDE F

D12257: [kstyle] drop QStyleOptionTabV3 in Qt 5 style plugin

zzag created this revision. zzag added reviewers: Breeze, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R31 Breeze BRANCH drop-QStyleOptionTabV3 REVISION DETAIL ht

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey updated this revision to Diff 32323. sharvey added a comment. - Adjust Y scale to 700 REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12252?vs=32314&id=32323 BRANCH enlarge-default-size (branched from master) REVISION DETAIL https://pha

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey added a comment. In D12252#247567 , @ngraham wrote: > Hmm, that's not the behavior I see at all. For me, `factor` appears to be 1 with not running a HiDPi scale factor, so I get an actual size that's essentially equal to the number it's

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

ngraham added a comment. Hmm, that's not the behavior I see at all. For me, `factor` appears to be 1 with not running a HiDPi scale factor, so I get an actual size that's essentially equal to the number it's multiplied by. (e.g. `return QSize(1024*factor, 700*factor)` yields window content t

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.9 - Build # 20 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/20/ Project: Plasma plasma-vault kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 16 Apr 2018 18:13:43 + Build duration: 43 sec and counting CONSOLE OUTPUT [

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey added a comment. In D12252#247563 , @ngraham wrote: > Much better! I think I'd still prefer 700 for the height, since at 600, the following KCMs have vertical scrollbars, but lose them at 700: 700 comes out a bit too large for me

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

ngraham added a comment. Much better! I think I'd still prefer 700 for the height, since at 600, the following KCMs have vertical scrollbars, but lose them at 700: - Fonts - Screen Edges - Window Behavior - KDE Wallet - File Associations - Network - Cookies - Keyboard - En

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey marked an inline comment as done. sharvey added a comment. In D12252#247508 , @zzag wrote: > What if sizeHint() returns a size which is bigger than screen size? Please use `QSize::boundedTo`. Can that happen, if we're basing `size

D12252: Enlarge window size: wide enough to show both sidebarsUse (adjusted) calculation in `SizeHint` to determine minimum window width to display both sidebars. Manually apply size with call to `res

sharvey marked an inline comment as done. sharvey added inline comments. INLINE COMMENTS > ngraham wrote in SettingsBase.cpp:159 > Don't remove this, or else it becomes possible to resize the window to > absurdly, unusably small sizes. The value could be changed, but we shouldn't > remove this

D12252: Enlarge window size: wide enough to show both sidebarsUse (adjusted) calculation in `SizeHint` to determine minimum window width to display both sidebars. Manually apply size with call to `res

sharvey updated this revision to Diff 32314. sharvey added a comment. - Adjust calculation; re-add `minimumSize()` property Updating D12252: Enlarge window size: wide enough to show both sidebars === Use (adjusted)

D12248: [Desktop Theme KCM] Port to new design

ngraham added a comment. This looks really good. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12248 To: broulik, #plasma, #vdg, mart Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12252: Enlarge window size: wide enough to show both sidebarsUse (adjusted) calculation in `SizeHint` to determine minimum window width to display both sidebars. Manually apply size with call to `res

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > SettingsBase.cpp:159 > helpActionMenu->setMenu( dynamic_cast( > factory()->container(QStringLiteral("help"), this) ) ); > -setMinimumSize(620,430);

D12252: Enlarge window size: wide enough to show both sidebarsUse (adjusted) calculation in `SizeHint` to determine minimum window width to display both sidebars. Manually apply size with call to `res

ngraham added a comment. Tested it out! The patch succeeds at altering the default size, but I'm not sure it accomplishes either of the goals of opening large enough to make the home screen and most KCMs look good, nor your intention of making it wide enough to always show both columns (not

D12252: Enlarge window size: wide enough to show both sidebarsUse (adjusted) calculation in `SizeHint` to determine minimum window width to display both sidebars. Manually apply size with call to `res

zzag added a comment. What if sizeHint() returns a size which is bigger than screen size? Please use `QSize::boundedTo`. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D12252 To: sharvey, ngraham, mart Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliez

D12252: Enlarge window size: wide enough to show both sidebarsUse (adjusted) calculation in `SizeHint` to determine minimum window width to display both sidebars. Manually apply size with call to `res

sharvey updated this revision to Diff 32306. sharvey added a comment. - Uncomment line left from testing Updating D12252: Enlarge window size: wide enough to show both sidebars === Use (adjusted) calculation in `Siz

D12252: Enlarge window size: wide enough to show both sidebarsUse (adjusted) calculation in `SizeHint` to determine minimum window width to display both sidebars. Manually apply size with call to `res

sharvey added a comment. The calculation is aiming for a minimum width of 1200px, which seems to be the minimum size needed to display both sidebars. Since the original calculation uses `physicalDotsPerInch`, I'm only able to use my own laptop as a test subject. It's a 15" 1920x1080 screen.

D12252: Enlarge window size: wide enough to show both sidebarsUse (adjusted) calculation in `SizeHint` to determine minimum window width to display both sidebars. Manually apply size with call to `res

sharvey created this revision. sharvey added reviewers: ngraham, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sharvey requested review of this revision. TEST PLAN - Compile systemsettings with path - Launch system settings (sy

D12055: Remove border around menubars

zzag reclaimed this revision. zzag added a comment. Oh, I misunderstood you. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D12055 To: zzag, #breeze Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apo

D12248: [Desktop Theme KCM] Port to new design

broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The preview code could luckily be left completely untouched.

D12088: port the ksplash kcm to the new design

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a6761883c8e7: port the ksplash kcm to the new design (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12088?vs=31958&id=32295 REVISION DET

D12148: update the wallpaper dialog to the new design

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:c66e998d7b6c: update the wallpaper dialog to the new design (authored by mart). REPOSITORY R120 Plasma Workspace CH

D12090: port the look and feel kcm to new design

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0b91f62e6920: port the look and feel kcm to new design (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12090?vs=32282&id=32293 REVISION D

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

abetts added a comment. In D12041#247368 , @Zren wrote: > In D12041#247352 , @abetts wrote: > > > Why not save the room on the right of the KCM and instead blur the actual image in the list? Move the

D12148: update the wallpaper dialog to the new design

mart updated this revision to Diff 32289. mart added a comment. - remove explicit width REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12148?vs=32281&id=32289 BRANCH phab/wallpaperdialredesign REVISION DETAIL https://phabricator.kde.org/D1214

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

Zren added a comment. In D12041#247352 , @abetts wrote: > Why not save the room on the right of the KCM and instead blur the actual image in the list? Move the controls closer to that list item? The arrangement looks off the way it shows in the

D12146: [Window List] Show pin icon only when in panel

This revision was automatically updated to reflect the committed changes. Closed by commit R119:eaa5b4364f8b: [Window List] Show pin icon only when in panel (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12146?vs=31967&id=32288 R

D12146: [Window List] Show pin icon only when in panel

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. good idea REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12146 To: broulik, #plasma, mart Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-moha

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

abetts added a comment. Why not save the room on the right of the KCM and instead blur the actual image in the list? Move the controls closer to that list item? The arrangement looks off the way it shows in the screenshots. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabrica

D12148: update the wallpaper dialog to the new design

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > config.qml:286-287 > +id: wallpapersGrid > anchors.fill: parent > - > -frameVisible: true > -h

D12148: update the wallpaper dialog to the new design

abetts added a comment. When you can, can you share a screenshot of the progress? I am so excited to see this! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12148 To: mart, #plasma, #vdg Cc: broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezh

D12117: handle in the top toolbar

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:a14d55fc9222: handle in the top toolbar (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D121

D12090: port the look and feel kcm to new design

mart updated this revision to Diff 32282. mart added a comment. - remove dead code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12090?vs=31959&id=32282 BRANCH phab/lookandfeelredesign REVISION DETAIL https://phabricator.kde.org/D12090 AFFECT

D12148: update the wallpaper dialog to the new design

mart updated this revision to Diff 32281. mart added a comment. - adapt to new design REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12148?vs=31970&id=32281 BRANCH phab/wallpaperdialredesign REVISION DETAIL https://phabricator.kde.org/D12148

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren added inline comments. INLINE COMMENTS > davidedmundson wrote in wallpaperplugin.cpp:26 > You don't need to do this. > > QPointer has a custom -> operator > > So m_newStuffDialog->setTitle works just fine. > > Same for in newStuffFinished I copy pasted from `image.cpp` ... which apparent

Minutes meeting week 16

logs and notes! Announcement: Since we will be meeting in-person next week, there will be no meeting on the 23rd. Also since I will reach home on 30th I will need someone to take care of meeting on the week 18. -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint

D8626: DDCUtil: Improved DDCUtil support for brightness control

broulik added a comment. lgtm INLINE COMMENTS > CMakeLists.txt:58 > + find_package(DDCUtil REQUIRED) > + add_definitions(-DWITH_DDCUTIL) >set_package_properties(DDCUtil we typically use `HAVE_xxx` but fine with me > ddcutilbrightness.h:27 > > -#ifdef WITH_DDCUTIL > +#if WITH_DDCUTIL

D11801: remove m_desktopContainments

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5898499c1f8f: remove m_desktopContainments (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11801?vs=31201&id=32264 REVISION DETAIL ht

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

davidedmundson added a comment. Code that here is fine. As you say we need a tidy way to reload that list in order to have this mergable. I'll have a think. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12041 To: Zren, #plasma Cc: davidedmundson, ngraham

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

davidedmundson added a comment. cool, seems mostly fine. One minor style comment INLINE COMMENTS > wallpaperplugin.cpp:26 > +m_newStuffDialog = new KNS3::DownloadDialog( > QString::fromLatin1("wallpaperplugin.knsrc") ); > +KNS3::DownloadDialog *strong = m_newStuffDialog.data(