Zren added inline comments.

INLINE COMMENTS

> davidedmundson wrote in wallpaperplugin.cpp:26
> You don't need to do this.
> 
> QPointer has a custom -> operator
> 
> So m_newStuffDialog->setTitle works just fine.
> 
> Same for in newStuffFinished

I copy pasted from `image.cpp` ... which apparently hasn't been touched in 4 
years since the import from kde-workspace.

- 
https://github.com/KDE/plasma-workspace/blame/master/wallpapers/image/image.cpp#L600

Will that function need updating too?

REPOSITORY
  R131 Plasma Wallpapers

REVISION DETAIL
  https://phabricator.kde.org/D12040

To: Zren, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to