broulik added a comment.
lgtm INLINE COMMENTS > CMakeLists.txt:58 > + find_package(DDCUtil REQUIRED) > + add_definitions(-DWITH_DDCUTIL) > set_package_properties(DDCUtil we typically use `HAVE_xxx` but fine with me > ddcutilbrightness.h:27 > > -#ifdef WITH_DDCUTIL > +#if WITH_DDCUTIL > #include <ddcutil_c_api.h> Doesn't this need to stay `ifdef`? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D8626 To: dvogel, broulik, davidedmundson Cc: asturmlechner, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
