zzag added inline comments.

INLINE COMMENTS

> SettingsBase.cpp:82
> +    // calculate base window size to an appropriate size
> +    qreal factor = QGuiApplication::primaryScreen()->devicePixelRatio();
> +    return QSize(1024*factor, 768*factor);

You forgot `const`.

Also, you could multiply whole QSize by `factor` so Qt will round width and 
height. ;-)

REPOSITORY
  R124 System Settings

BRANCH
  enlarge-default-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12252

To: sharvey, ngraham, mart
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to