D10002: Improve header and screenshots

abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10002 To: ngraham, apol, abetts, andreaska, colomar, #discover_software_store, #vdg Cc: plasma-devel, Zre

D10002: Improve header and screenshots

ngraham added a comment. I know it seems like we're just changing the design over and over again, but IMHO this is an improvement over what I proposed and landed a few days ago--being even more true to the visual language we've established. Also, I want the version of Discover in Plasma

D10002: Improve header and screenshots

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10002 To: ngraham, apol, abetts, andreaska, colomar, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10002: Improve header and screenshots

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10002 To: ngraham, apol, abetts, andreaska, colomar, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, pro

D10002: Improve header and screenshots

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10002 To: ngraham, apol, abetts, andreaska, colomar, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10002: Improve header and screenshots

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10002 To: ngraham, apol, abetts, andreaska, colomar, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterbe

D10002: Improve header and screenshots

ngraham created this revision. ngraham added reviewers: apol, abetts, andreaska, colomar, Discover Software Store, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Increase

Allow removal of taskbar panel shadow in Wayland?

Hi, I keep my taskbar panel on the left side of my screen and use a script at startup to hide the shadow: #!/bin/sh for WID in `xwininfo -root -tree | sed '/"Plasma": ("plasmashell" "plasmashell")/!d; s/^ *\([^ ]*\) .*/\1/g'`; do xprop -id $WID -remove _KDE_NET_WM_SHADOW done This doesn't wor

D9072: make ksshaskpass work with git-lfs

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. In https://phabricator.kde.org/D9072#193866, @mkoller wrote: > so you mean instead of a one line change fiddling with file descriptors is a better way ? > I don't think so. > > And

D9072: make ksshaskpass work with git-lfs

mkoller added a comment. so you mean instead of a one line change fiddling with file descriptors is a better way ? I don't think so. And effectively I was told that passing a 0 pointer to kwallet is wrong. https://mail.kde.org/pipermail/kde-frameworks-devel/2017-May/045085.html

D9993: Improve quality of images in notifications (Bug 385097)

rkron added a comment. I do not have commit access. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9993 To: rkron, #plasma_workspaces, #plasma, broulik Cc: broulik, ngraham, plasma-devel, #plasma_workspaces, #plasma, ZrenBot, gassaf, progwolff, franciscofe

D9998: Actually quit threads nicely

fvogt added a comment. In https://phabricator.kde.org/D9998#193836, @anthonyfieroni wrote: > If it's not running event loop why run is called? That's what a QThread is: > A QThread object manages one thread of control within the program. QThreads begin executing in run(). By

D9998: Actually quit threads nicely

anthonyfieroni added a comment. If it's not running event loop why run is called? REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D9998 To: fvogt, #plasma, ivan, anthonyfieroni Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuter

D9998: Actually quit threads nicely

fvogt added a reviewer: anthonyfieroni. REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D9998 To: fvogt, #plasma, ivan, anthonyfieroni Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9998: Actually quit threads nicely

fvogt created this revision. fvogt added reviewers: Plasma, ivan. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY https://phabricator.kde.org/R161:27c0245b1715044cf4d401f1c9d7e7a915a4f3c5 ("[resources] Nicely quit threads") has no effe

D9976: Display version alongside source, and use a combobox to switch between them

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store BRANCH actually-use-combobox-to-choose-source REVISION DETAIL https://phabricator.kde.org/D9976 To: ngraham, apol, colomar, abetts, #discover_software_store, #vdg, andreaska Cc: plasma-devel, romangg, Zre

D9976: Display version alongside source, and use a combobox to switch between them

ngraham updated this revision to Diff 25692. ngraham added a comment. Merge master and fix the issue of "installed:" getting appended to the origin string REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9976?vs=25640&id=25692 BRANCH actua

D9993: Improve quality of images in notifications (Bug 385097)

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks for looking into this! Do you have commit access? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9993 To: rkron, #plasma_workspaces, #plasma, br

D9995: Allow longer app names in titlebar without eliding

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9995 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9995: Allow longer app names in titlebar without eliding

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9995 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9995: Allow longer app names in titlebar without eliding

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Previously, long app names in the titlebar w

D9993: Improve quality of images in notifications (Bug 385097)

rkron edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9993 To: rkron, #plasma_workspaces, #plasma Cc: ngraham, plasma-devel, #plasma_workspaces, #plasma, ZrenBot, gassaf, progwolff, franciscofernandes, lesliezhai, ali-mohame

D9993: Improve quality of images in notifications (Bug 385097)

ngraham edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9993 To: rkron, #plasma_workspaces, #plasma Cc: ngraham, plasma-devel, #plasma_workspaces, #plasma, ZrenBot, gassaf, progwolff, franciscofernandes, lesliezhai, ali-moha

D9072: make ksshaskpass work with git-lfs

fvogt added a comment. In https://phabricator.kde.org/D9072#189550, @mkoller wrote: > In https://phabricator.kde.org/D9072#189303, @fvogt wrote: > > > Looks good to me, but I wonder whether > > > > > KWallet writes an error to stderr when a 0-winId is given to openWallet() which i

D9993: Improve quality of images in notifications (Bug 385097)

rkron created this revision. rkron added reviewers: Plasma: Workspaces, Plasma. rkron added projects: Spectacle, Plasma: Workspaces. Restricted Application edited projects, added Plasma; removed Plasma: Workspaces. Restricted Application added a subscriber: plasma-devel. rkron requested review of

D9980: Do not reset the size of window once we move it to an edge

graesslin added inline comments. INLINE COMMENTS > jgrulich wrote in shell_client.cpp:300-301 > I don't have the log from WAYLAND_DEBUG enabled at this moment, but there was > definitely this state advertised together with the correct size, at least > from what I remember it called configure (

D9980: Do not reset the size of window once we move it to an edge

jgrulich added a comment. In https://phabricator.kde.org/D9980#193513, @graesslin wrote: > Please also add a test case exposing the problem. Ok, will try to do so. INLINE COMMENTS > graesslin wrote in shell_client.cpp:300-301 > we need to send the configure. Because the state als

D9792: even slimmer scrollbars

rikmills added a comment. In https://phabricator.kde.org/D9792#193697, @hpereiradacosta wrote: > In https://phabricator.kde.org/D9792#193473, @rikmills wrote: > > > In Neon and Kubuntu CI with Qt 5.9.3 > > > > https://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/

D9792: even slimmer scrollbars

hpereiradacosta added a comment. Fixed with https://commits.kde.org/breeze/fc830e4710a9994a13911ac6cbc60ffda8f27715 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9792 To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts Cc: rikmills, davidedmundson, ngraham,

D9792: even slimmer scrollbars

hpereiradacosta added a comment. In https://phabricator.kde.org/D9792#193473, @rikmills wrote: > In Neon and Kubuntu CI with Qt 5.9.3 > > https://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/186/console > > 17:55:15 /workspace/build/kstyle/breezestyle.cpp: In mem

D9991: Remove unnecessary dependency on QtScript

This revision was automatically updated to reflect the committed changes. Closed by commit R112:684a95a6ef0b: Remove unnecessary dependency on QtScript (authored by vkrause). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9991?vs=25682&id=25683 REVISION DETAIL

D9991: Remove unnecessary dependency on QtScript

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R112 Milou BRANCH master REVISION DETAIL https://phabricator.kde.org/D9991 To: vkrause, #plasma, bshah Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, a

D9991: Remove unnecessary dependency on QtScript

vkrause created this revision. vkrause added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. vkrause requested review of this revision. REPOSITORY R112 Milou BRANCH master REVISION DETAIL https://phabricator.kde.o

KDE CI: Plasma libksysguard kf5-qt5 SUSEQt5.9 - Build # 26 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20SUSEQt5.9/26/ Project: Plasma libksysguard kf5-qt5 SUSEQt5.9 Date of build: Sat, 20 Jan 2018 09:44:28 + Build duration: 1 min 49 sec and counting JUnit Tests Name

KDE CI: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 - Build # 14 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20FreeBSDQt5.9/14/ Project: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 20 Jan 2018 09:44:28 + Build duration: 1 min 28 sec and counting JUnit Tests

D9944: [WIP]expose if the tablet mode switch is available

mart added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > graesslin wrote in tabletmodemanager.cpp:87 > makes sense. VirtualKeyboard also accesses the information through input ok, i'll try to add an api for that in thir rr then REPOSITORY

KDE CI: Plasma libksysguard kf5-qt5 SUSEQt5.9 - Build # 25 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20SUSEQt5.9/25/ Project: Plasma libksysguard kf5-qt5 SUSEQt5.9 Date of build: Sat, 20 Jan 2018 09:27:03 + Build duration: 1 min 49 sec and counting CONSOLE OUTPUT [

KDE CI: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 - Build # 13 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20FreeBSDQt5.9/13/ Project: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 20 Jan 2018 09:27:03 + Build duration: 1 min 37 sec and counting CONSOLE OUTPUT

KDE CI: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 - Build # 12 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20FreeBSDQt5.9/12/ Project: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 20 Jan 2018 09:14:38 + Build duration: 1 min 35 sec and counting CONSOLE OUTPUT

KDE CI: Plasma libksysguard kf5-qt5 SUSEQt5.9 - Build # 24 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20SUSEQt5.9/24/ Project: Plasma libksysguard kf5-qt5 SUSEQt5.9 Date of build: Sat, 20 Jan 2018 09:14:38 + Build duration: 1 min 31 sec and counting CONSOLE OUTPUT [

KDE CI: Plasma libksysguard kf5-qt5 SUSEQt5.9 - Build # 23 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20SUSEQt5.9/23/ Project: Plasma libksysguard kf5-qt5 SUSEQt5.9 Date of build: Sat, 20 Jan 2018 08:59:53 + Build duration: 1 min 19 sec and counting CONSOLE OUTPUT [

KDE CI: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 - Build # 11 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20FreeBSDQt5.9/11/ Project: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 20 Jan 2018 08:59:53 + Build duration: 1 min 2 sec and counting CONSOLE OUTPUT

KDE CI: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 - Build # 10 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20FreeBSDQt5.9/10/ Project: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 20 Jan 2018 08:56:48 + Build duration: 1 min 21 sec and counting CONSOLE OUTPUT

KDE CI: Plasma libksysguard kf5-qt5 SUSEQt5.9 - Build # 22 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20SUSEQt5.9/22/ Project: Plasma libksysguard kf5-qt5 SUSEQt5.9 Date of build: Sat, 20 Jan 2018 08:56:48 + Build duration: 1 min 11 sec and counting CONSOLE OUTPUT [

KDE CI: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 - Build # 9 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20FreeBSDQt5.9/9/ Project: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 20 Jan 2018 08:50:33 + Build duration: 2 min 3 sec and counting CONSOLE OUTPUT

KDE CI: Plasma libksysguard kf5-qt5 SUSEQt5.9 - Build # 21 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20SUSEQt5.9/21/ Project: Plasma libksysguard kf5-qt5 SUSEQt5.9 Date of build: Sat, 20 Jan 2018 08:50:33 + Build duration: 1 min 59 sec and counting CONSOLE OUTPUT [