rkron created this revision. rkron added reviewers: Plasma: Workspaces, Plasma. rkron added projects: Spectacle, Plasma: Workspaces. Restricted Application edited projects, added Plasma; removed Plasma: Workspaces. Restricted Application added a subscriber: plasma-devel. rkron requested review of this revision.
REVISION SUMMARY This patch is to improve the quality of images in notifications as reported in Bug 385097 <https://bugs.kde.org/show_bug.cgi?id=385097>. It is still not perfect because KIO::PreviewJob is used to create the thumbnail, and it only produces two sizes, 128px and 256px, so it is likely that a small image will be scaled up, blurring it somewhat. I took two screenshots of the same Dolphin window. Here is the before, without the patch: F5665511: Dolphin-screenshot-notification-before.png <https://phabricator.kde.org/F5665511> And the after, with the patch: F5665513: Dolphin-screenshot-notification-after.png <https://phabricator.kde.org/F5665513> Better, but still not perfect. TEST PLAN Take screenshots with Spectacle with and without the patched libnotificationshelperplugin library and observe the image quality in the notification. plasmashell must be restarted when the library file is changed for it to take effect. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9993 AFFECTED FILES applets/notifications/plugin/thumbnailer.cpp To: rkron, #plasma_workspaces, #plasma Cc: plasma-devel, #plasma_workspaces, #plasma, ZrenBot, gassaf, ngraham, progwolff, franciscofernandes, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
