fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land.
In https://phabricator.kde.org/D9072#193866, @mkoller wrote: > so you mean instead of a one line change fiddling with file descriptors is a better way ? > I don't think so. > > And effectively I was told that passing a 0 pointer to kwallet is wrong. > https://mail.kde.org/pipermail/kde-frameworks-devel/2017-May/045085.html Obviously your fix is correct and necessary, I never stated the opposite. I merely suggested that a more generic way in addition to this would prevent future issues. I'd say you can commit this to the Plasma/5.12 branch. REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9072 To: mkoller, cfeck, jriddell, whiting, fvogt Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
